1837246 - Crash in [@ dghmpg64.dll]

Status: RESOLVED FIXED

(External Software Affecting Firefox :: Other, defect, P2)

Description

[Donal Meehan [:dmeehan]]

Crash report: https://crash-stats.mozilla.org/report/index/e952eeca-98f5-414d-b40b-785d80230607

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 5 frames of crashing thread:

0  dghmpg64.dll  dghmpg64.dll@0x45a68  
1  dghmpg64.dll  dghmpg64.dll@0x5ce4c  
2  dghmpg64.dll  dghmpg64.dll@0x8e3a8  
3  dghmpg64.dll  dghmpg64.dll@0x5e8eb  
4  dghmpg64.dll  dghmpg64.dll@0xe339f  

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 20 desktop browser crashes on beta (startup)

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox115 (beta). However, the bug still isn't assigned.

:gcp, could you please find an assignee for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 3

[Greg Stoll :gstoll]

Windows DLLBlocklist request form

1. How were we aware of the problem?
   Topcrasher

2. What is a suspicious product causing the problem?
   Kingsoft Security software

3. Is the product downloadable? If so, do we have a local repro?
   The product is downloadable, but I haven't seen this module get injected into Firefox locally.

4. Which OS versions does the problem occur on?
   Windows 7, 10, 11

5. Which process types does the problem occur on?
   Only the browser process

6. What is the maximum version of the module in the crash reports?
   2023.5.31.1367

7. Is the issue fixed by a newer version of the product?
   According to telemetry, 2023.5.31.1367 is the newest version of the module we've seen.

8. Do we have data about the module in the third-party-module ping?
   Yes

9. Do we know how the module is loaded?
   Seems to be loaded through CoInitializeEx(), which means that it should be safe to block.

10. Describe your conclusion.
    We should block dghmpg64.dll versions 2023.5.31.1367 and earlier in the browser process only.

Comment 4

[Greg Stoll :gstoll]

Attachment: Bug 1837246 - block Kingsoft DLL (dghmpg64.dll) to avoid crashes r=gsvelto

Depends on D180373

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8fe3872bfe82
block Kingsoft DLL (dghmpg64.dll) to avoid crashes r=gsvelto

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8fe3872bfe82

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:gstoll, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox115 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Greg Stoll :gstoll]

Attachment: Bug 1837246 - block Kingsoft DLL (dghmpg64.dll) to avoid crashes

Depends on D180373

Original Revision: https://phabricator.services.mozilla.com/D180374

Comment 9

[Phabricator Automation]

Uplift Approval Request

• Needs manual QE test: no
• Risk associated with taking this patch: low
• Fix verified in Nightly: yes
• User impact if declined: users won't get a fix for a topcrasher
• Steps to reproduce for manual QE testing: n/a
• Code covered by automated testing: no
• Explanation of risk level: just adding a blocklist entry
• String changes made/needed: no
• Is Android affected?: no

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 11

[Greg Stoll :gstoll]

Attachment: Bug 1837246: Block Kingsoft DLL (dghmpg64.dll) in all versions to avoid crashes r=gsvelto

Depends on D181651

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b713d0deed35
Block Kingsoft DLL (dghmpg64.dll) in all versions to avoid crashes r=gsvelto

Comment 13

[Greg Stoll :gstoll]

Similar to bug 1837242, this is also crashing again because a newer version was released. I'm going to block them both in all versions.

Comment 14

[Greg Stoll :gstoll]

Attachment: Bug 1837246: Block Kingsoft DLL (dghmpg64.dll) in all versions to avoid crashes r=gsvelto

Depends on D181651

Original Revision: https://phabricator.services.mozilla.com/D181652

Comment 15

[Phabricator Automation]

Uplift Approval Request

• Fix verified in Nightly: yes
• Explanation of risk level: just extended a blocklist entry to block all versions
• Is Android affected?: no
• Risk associated with taking this patch: low
• User impact if declined: users won't get a fix for a topcrasher
• Code covered by automated testing: no
• String changes made/needed: no
• Steps to reproduce for manual QE testing: n/a
• Needs manual QE test: no

Comment 16

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b713d0deed35

Comment 17

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3673ad484e13ce731e7fc368a7e6b114d5eeee44

Comment 18

[Greg Stoll :gstoll]

Contacted a public address for Kingsoft in the hopes they'll be able to take a look at this.

Comment 19

[Donal Meehan [:dmeehan]]

As mentioned in the related bug https://bugzilla.mozilla.org/show_bug.cgi?id=1837242#c23
Users are hitting this in 115