1837253 - Introduce read-only index property as a replacement for pseudo-private _tPos

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task)

Description

[Dão Gottwald [:dao]]

_tPos is used quite a bit by external code, so there's no point in pretending it's private anymore. We should add a proper public, read-only property on tabs, perhaps index or position.

Comment 1

[Jonathan Sudiaman [:jsudiaman]]

The tricky bit is that assignments to _tPos are done in tabbrowser.js, but MozTabbrowserTab (the tab object) itself is defined in tab.js. So, it is not a simple matter of making a private setter + public getter.

I think we should leave the _tPos assignments as is, and create a public getter (called tabIndex) in MozTabbrowserTab which returns this._tPos. Then replace all outside references to _tPos accordingly.

Nonetheless, this seems like a good fit for a mentored bug.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1837253 - Give tabs a public index property. r?jsudiaman!

Not tabIndex as the bug's summary suggests: every element inherits that one from Element. The underscored _index stays as the write path, since the tabbrowser sets it from outside the tab's own class, and the session store's check for a tab that never got a position becomes a read of the getter.

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1837253 - Use the tab's index property in tests. r?jsudiaman!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2bb2aff2f3d0
https://hg.mozilla.org/integration/autoland/rev/2472454448e4
Give tabs a public index property. r=jsudiaman,tabbrowser-reviewers
https://github.com/mozilla-firefox/firefox/commit/2e063ee8f9b5
https://hg.mozilla.org/integration/autoland/rev/2a60e54ede11
Use the tab's index property in tests. r=jsudiaman,tabbrowser-reviewers

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/2472454448e4
https://hg.mozilla.org/mozilla-central/rev/2a60e54ede11