1837407 - Add support.mozilla.org to special UITour allow-list in UITourChild

Status: VERIFIED FIXED

(Firefox :: Tours, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

Bug 1579517 describes how if users ever clear recent site preferences via the "Clear Recent History" dialog, that the default permissions (including the default UITour permission for support.mozilla.org) will have their value set to UNKNOWN_ACTION, which prevents UITour from working on that page.

This is likely the root cause of the uitour-broken events we've been seeing from some users visiting our switching devices SUMO page.

The quick workaround here is to do the same thing that was done in bug 1557153 for Skyline, which blanket-allowed the www.mozilla.org domain, hardcoded into UITourChild. I suggest we do the same, but then actually try fixing bug 1579517 once that's done before it bites us again in the future.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

[Tracking Requested - why for this release]:

If we're doing a dot release for 114, I'd like to nominate this as a ride-along. We're seeing a small but significant set of users that can't use the setup assistant on SUMO for switching devices, and we suspect this bug is the root cause.

Comment 2

[Ray Fambro]

@Mike -- Thanks for investigating this issue. Your proposed plan sounds good to me. Let's proceed with the workaround and follow up by fixing the bug. Let's request uplift for a dot release if there's one coming up.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1837407 - Workaround UITour default permissions overridden by UNKNOWN_ACTION for SUMO. r?Mardak!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40bbb2125064
Workaround UITour default permissions overridden by UNKNOWN_ACTION for SUMO. r=Mardak

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/40bbb2125064

Comment 6

[Emil Ghitta, QA [:emilghitta]]

This is verified fixed using Firefox 116.0a1 (BuildId:20230611214645) on Windows 10 64bit & macOS 11

The Wizard does not get disabled when clearing site preferences via the "Clear Recent History" panel and refreshing the Switching Devices SUMO page.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9338282 [details]
Bug 1837407 - Workaround UITour default permissions overridden by UNKNOWN_ACTION for SUMO. r?Mardak!

Beta/Release Uplift Approval Request

• User impact if declined: Users who have cleared their history in their profile will not be able to use the setup assistant on SUMO at https://support.mozilla.org/en-US/kb/switching-devices.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a copy of a similar workaround fix that was done for the www.mozilla.org domain for Skyline back a few years ago. It's a one-liner static addition of support.mozilla.org to a condition that checks for UITour capability.
• String changes made/needed: None.
• Is Android affected?: No

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9338282 [details]
Bug 1837407 - Workaround UITour default permissions overridden by UNKNOWN_ACTION for SUMO. r?Mardak!

Approved for 115.0b5.

Comment 9

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/109c7aa4e8be

Comment 10

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 115.0b6 (BuildId:20230615175802) on Windows 10 64bit and macOS 11

Comment 11

[Pascal Chevrel:pascalc]

Comment on attachment 9338282 [details]
Bug 1837407 - Workaround UITour default permissions overridden by UNKNOWN_ACTION for SUMO. r?Mardak!

There was no uplift request for release but it seems that this is an oversight as there was a tracking request for 114. Taking for our 114.0.2.

Comment 12

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-release/rev/03507655f79d

Comment 13

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 114.0.2 (BuildId:20230619081400) on Windows 10 64bit and macOS 11