1837484 - Make shortestPaths fuzzable again

Status: NEW

(Core :: JavaScript Engine, task, P3)

Description

[Steve Fink [:sfink] [:s:]]

Over in bug 1833545 we marked shortestPaths as fuzzing unsafe. Coincidentally, I stumbled across a bug 1822710 filed 3 months ago and fixed it, iain asked for a test, and when I went to add the test I read this header:

// The shortestPaths function exists solely to let the fuzzers go to town and
// exercise the code paths it calls into, hence the only things to assert
// relate to the shortestPaths test function API.

So... the only purpose of shortestPaths is for fuzzers, and we are now preventing fuzzers from using it because it exposes internal details that we assert will not leak out. :-(

I thought I should at least file a bug to do whatever is required to re-enable it, even if I don't know what that is.

Comment 1

[Steve Fink [:sfink] [:s:]]

One possibility would be to add a flag to internal objects so that shortestPaths would skip them, and we could assert that they are never exposed any other way. Not worth it for just shortestPaths probably, but maybe it's a check we want anyway?

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

The internal object flag is open under Bug 1835087

Comment 3

[Steve Fink [:sfink] [:s:]]

(In reply to Matthew Gaudet (he/him) [:mgaudet] from comment #2)

The internal object flag is open under Bug 1835087

Ah! You're ahead of me.