1837499 - [ci] Replace 'multi_dep' loader with new 'from_deps' transforms

Status: RESOLVED FIXED

(Fenix :: General, task)

Description

[Andrew Halberstadt [:ahal]]

I'm in the process of consolidating some code that was copy pasted a ton of times from project to project. Namely the multi_dep loader and related transforms. I've re-implemented all the functionality it provides in the upstream taskgraph repo and am removing code in the various projects that use it.

Thanks to the taskgraph full --diff flag, I'll be able to ensure that the generated taskgraphs are identical before/after my changes, so the risk of breaking something will be low.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: GitHub Pull Request

Comment 2

[BMO Github Automation]

Authored by https://github.com/ahal
https://github.com/mozilla-mobile/firefox-android/commit/3b69d4cb38b85de3a7b303206377d679dd243bd4
[main] Bug 1837499 - Update Taskgraph dependencies

Authored by https://github.com/ahal
https://github.com/mozilla-mobile/firefox-android/commit/35e6a7067f7ecf255d2f2d046baf781cc0ace925
[main] Bug 1837499 - convert signing tasks to from_deps

Authored by https://github.com/ahal
https://github.com/mozilla-mobile/firefox-android/commit/67586c2aeae4aed7496e8a7c6931986d8afa2ea7
[main] Bug 1837499 - convert beetmover tasks to from_deps

Authored by https://github.com/ahal
https://github.com/mozilla-mobile/firefox-android/commit/495710250655a72cec2947c5c0946e3406de588c
[main] Bug 1837499 - convert version-bump tasks to from_deps

Authored by https://github.com/ahal
https://github.com/mozilla-mobile/firefox-android/commit/02144a4cd00650e9514c86d65362d2abf8f0071e
[main] Bug 1837499 - convert push-apk tasks to from_deps

Authored by https://github.com/ahal
https://github.com/mozilla-mobile/firefox-android/commit/aaf755d56a891b2ec97a61cbc36dc88515325f54
[main] Bug 1837499 - convert github-release-components tasks to from_deps

Authored by https://github.com/ahal
https://github.com/mozilla-mobile/firefox-android/commit/f6418a5c40e23971c5a29539c490b600b26e1b45
[main] Bug 1837499 - convert github-release-apk tasks to from_deps

Authored by https://github.com/ahal
https://github.com/mozilla-mobile/firefox-android/commit/372658838513b14f69ae997927cad651bcb666f8
[main] Bug 1837499 - convert signing-apk tasks to from_deps

Authored by https://github.com/ahal
https://github.com/mozilla-mobile/firefox-android/commit/b1bbdc9c7f7b1dc653ae48ec4d627d87cc751c8e
[main] Bug 1837499 - convert 'post' tasks to from_deps transforms

Authored by https://github.com/ahal
https://github.com/mozilla-mobile/firefox-android/commit/5573aa9b90188b1edac38a66d0b0bebed106a702
[main] Bug 1837499 - remove multi_dep loader and related transforms

Comment 3

[miralobontiu]

Hi Andrew,

Is there anything that the QA team can verify on this ticket?

Thank you!

Comment 4

[Andrew Halberstadt [:ahal]]

Nope, I don't think there's any verification necessary. This was just a refactoring of tasks and thanks to taskgraph --diff we can be confident that the end tasks that get submitted to Taskcluster are identical.