1837546 - [wpt-sync] Sync PR 40466 - [css-flex] Try a more conservative intrinsic sizing algorithm

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 40466 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40466
Details from upstream follow.

David Grogan <[e-mail]> wrote:

[css-flex] Try a more conservative intrinsic sizing algorithm

Our first attempt at a better algorithm was not compatible with the web.
This version gives behavior closer to what is currently shipping in all
browsers.

The difference in this version affects only single-line row containers'
min-content sizes. For such containers where no items are growing from
their flex basis to their desired min contribution, an item's final
contribution to the container's min-content size is (1) its flex-basis
if the item has a 0 flex factor in whichever direction it wants to go
(shrink if flex-basis > min-content contribution, grow otherwise);
otherwise: (2) its min-content contribution.

This will probably only be enabled for a few days, but will give us good
compat data even so.

Bug: 240765
Change-Id: Ib8ae101ec88b4f0e543c8f4ecb713edb68074cb4
Reviewed-on: https://chromium-review.googlesource.com/4602419
WPT-Export-Revision: f70a4b01fa35604fca24482d35e3e254204321f0

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9fbf3e64c4b47cdb8bc6027b5e3f0cad2623cae8

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 5 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 1 tests and 9 subtests

Status Summary

Firefox

OK : 1
PASS: 1
FAIL: 8

Chrome

OK : 1
PASS: 1
FAIL: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-flexbox/intrinsic-size/row-005.html [wpt.fyi]
  • .floating-flexbox 1: FAIL (Chrome: FAIL)
  • .floating-flexbox 2: FAIL (Chrome: FAIL)
  • .floating-flexbox 3: FAIL (Chrome: FAIL)
  • .floating-flexbox 4: FAIL (Chrome: FAIL)
  • .floating-flexbox 5: FAIL (Chrome: FAIL)
  • .floating-flexbox 6: FAIL (Chrome: FAIL)
  • .floating-flexbox 7: FAIL (Chrome: FAIL)
  • .floating-flexbox 8: FAIL (Chrome: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3350727e5b3
[wpt PR 40466] - [css-flex] Try a more conservative intrinsic sizing algorithm, a=testonly
https://hg.mozilla.org/integration/autoland/rev/4b450422021f
[wpt PR 40466] - Update wpt metadata, a=testonly

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b3350727e5b3
https://hg.mozilla.org/mozilla-central/rev/4b450422021f