1837599 - Wikipedia and YouTube topic-specific search engines do not display history suggestions for previous searches

Status: VERIFIED FIXED

(Firefox for Android :: Search, defect, P1)

Description

[Alexandru Putanu [:aputanu]]

Preconditions

1. Perform some searches with the Wikipedia and YouTube topic-specific search engines. (To add YouTube to the search engine list go to Settings > Search > + Add search engine > select YouTube and tap on the check mark in the right upper corner).
2. Go to Settings > Search engine. Make sure that the "Search browsing history" option is enabled.

Steps to reproduce

1. Tap on the dropdown menu from the Google search engine icon.
2. Select the Wikipedia topic-specific search engine.
3. Type in a valid search term (related to the previous searches with Wikipedia as search engine).
4. Observe if search suggestions are displayed.
5. Repeat Steps 2-4 with the YouTube topic-specific search engine selected.

Expected behavior

Temporary selected Topic-specific search engines (amazon.com, eBay, Wikipedia, Reddit, YouTube) should display history visit suggestions from searches made with the same search engine.

Actual behavior

Temporary selected Wikipedia and YouTube topic-specific search engines do not display history visit suggestions.

Device information

• Firefox version: Nightly 116
• Android device model: Google Pixel 7
• Android OS version: Android 13

Comment 1

[Chris Peterson [:cpeterson]]

This would be a good fix to uplift to Beta 115, since we hope to ship Unified Search in 115.

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1837599 - Allow history visits containing mobile subdomains to be displayed in the awesome bar (#2455)

Comment 3

[BMO Github Automation]

Authored by https://github.com/Alexandru2909
https://github.com/mozilla-mobile/firefox-android/commit/3a2135d7a564e72c86198da1b43c67b0d6c5387f
[main] Bug 1837599 - Allow history visits containing mobile subdomains to be displayed in the awesome bar

Comment 4

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:aputanu, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox115 to wontfix.

For more information, please visit BugBot documentation.

Comment 5

[Delia Pop (Android QA)]

Attachment: history_suggestions.png

Verified as fixed on the latest Nightly 116.0a1 from 06/20.
The history suggestions for Wikipedia and YouTube are now displayed.
Marking as verified for 116.
Devices used:

• Lenovo Yoga Tab 11 (Android 11).
• Samsung Galaxy A53 5G (Android 13).
• Google Pixel 4 (Android 13).
• Google Pixel 7 (Android 14).

Comment 6

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1837599 - Allow history visits containing mobile subdomains to be displayed in the awesome bar (backport #2455) (#2552)

Comment 7

[Alexandru Putanu [:aputanu]]

Comment on attachment 9340175 [details] [review]
[mozilla-mobile/firefox-android] Bug 1837599 - Allow history visits containing mobile subdomains to be displayed in the awesome bar (backport #2455) (#2552)

Beta/Release Uplift Approval Request

• User impact if declined: Users will not be able to search history visits using Wikipedia and Youtube as search engines
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Tap on the dropdown menu from the Google search engine icon.
  Select the Wikipedia topic-specific search engine.
  Type in a valid search term (related to the history visits previously created with the Wikipedia search engine).
  Observe if search suggestions are displayed.
  Repeat Steps 2-4 with the YouTube topic-specific search engine selected.
• List of other uplifts needed: Bug 1831107
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change is not risky as it's been verified in Nightly and only affects the filtering done for bookmarks.
• String changes made/needed: None
• Is Android affected?: Yes

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9340175 [details] [review]
[mozilla-mobile/firefox-android] Bug 1837599 - Allow history visits containing mobile subdomains to be displayed in the awesome bar (backport #2455) (#2552)

Approved for Fenix 115.0b9.

Comment 9

[BMO Github Automation]

Authored by https://github.com/Alexandru2909
https://github.com/mozilla-mobile/firefox-android/commit/fab41fac1f18634116afa31a525e03d79d57b2ae
[releases_v115] Bug 1837599 - Allow history visits containing mobile subdomains to be displayed in the awesome bar

Comment 10

[Lorand Janos]

Verified as Fixed on Beta 115.0b9 as well.
Devices used for testing:

• Huawei Mate 20 Lite(Android 10)
• Lenovo Tab P11 Plus (Android 12)
• Samsung Galaxy Note 8 (Android 9)
• Oppo Find X5 (Android 13)
• Huawei MediaPad M2 (Android 5.1.1)