1837773 - select.namedItem("") should return null, not one of the select's options

Status: RESOLVED FIXED

(Core :: DOM: Forms, defect)

Description

[Thomas Wisniewski [:twisniewski]]

This seems minor, but other browsers pass this test, and it's the last test we are failing in the html semantics/select element WPTs (which Safari now fully passes), so wIth luck it might just be a quick win to fix it.

Comment 1

[Edgar Chen [:edgar]]

Relevant code are in https://searchfox.org/mozilla-central/rev/d307d4d9f06dab6d16e963a4318e5e8ff4899141/dom/html/HTMLOptionsCollection.cpp#145-161.

Comment 2

[Srikavin Ramkumar]

Attachment: Bug 1837773 - Return null for empty strings in HTMLOptionsCollection::NamedGetter. r=edgar

This updates the named getter implementation to match the spec.
See: https://dom.spec.whatwg.org/#dom-htmlcollection-nameditem-key

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 4

[psychpsyo]

I am working on this.

Comment 5

[psychpsyo]

Attachment: Bug 1837773 - Make select.namedItem("") return null

It used to not return null if there was an option with and id of "".

This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1837773

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52b8d9699529
Make select.namedItem("") return null r=farre

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/52b8d9699529