1837831 - Unable to get new messages for RSS feeds if "Remember websites and links I've visited" is unchecked.

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[tgentrynz]

Steps to reproduce:

In Windows and Debian, I can reproduce by following these steps:

1. Open Thunderbird 115.0b1
2. Open Settings from the App Menu (to change preferences.)
3. Modify the option "Settings->Privacy & Security->Web Content->Remember websites and links I've visited" so that it is unchecked (So Thunderbird does NOT remember websites and links I've visited).
4. Run the Get Messages action for a Feed Account with at least one feed subscription or for a specific feed (to get new feed items) (it does not matter if there are new messages in the feed or not).

Actual results:

1. New items are NOT downloaded.
2. Nothing is shown in the status bar.
3. Icons for the feeds are not updated.
4. "uncaught exception: 2147942487" is logged in the console with each attempt

Expected results:

1. New items are downloaded.
2. The status bar updates to inform user that the feed is being read, when the task is complete the status bar updates to inform the user that the feed has been read, with the number of new messages also displayed.
3. Icons are updated to reflect the icon used by the feed.
4. There is no uncaught exception logged to the console.

I am able to get the expected results in the current release build on Windows and 114.0b6 on Debian, so I believe this is a new issue in 115.0b01.

Comment 1

[tgentrynz]

I'm not really familiar with the tools or the source, but I think the problem is initiated from:
resource:///modules/FeedUtils.jsm line 345: await FeedUtils.getFavicon(folder, url);

And the first instance of the value 2147942487 is as the value of error in:
resource://gre/modules/History.sys.mjs line 1563: reject(error);

I think after that happens, the function fails and nothing else happens towards updating the feed.

If that's the case, it may have been introduced here:
https://phabricator.services.mozilla.com/D177234
In response to this bug 1824272

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 1837831 - With "Remember websites and links I've visited" unchecked getting feed favicon won't work. r=#thunderbird-reviewers

Don't try to get favicon if places.history.enabled is false.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b443e0785f4b
With "Remember websites and links I've visited" unchecked getting feed favicon won't work. r=leftmostcat

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9338774 [details]
Bug 1837831 - With "Remember websites and links I've visited" unchecked getting feed favicon won't work. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1824272
User impact if declined: no favicon if given setting is ticked
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): safe

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9338774 [details]
Bug 1837831 - With "Remember websites and links I've visited" unchecked getting feed favicon won't work. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 6

[Daniel Darnell [:dandarnell]]

Thunderbird 115.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/113b1cc683a1