183788 - request mail auto-cc not working for original request

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Asa Dotzler [:asa]]

at bmo I have set up a flag, "approval1.3a", which is not specifically
requestable but is supposed to auto-cc [e-mail] and [e-mail].
The request approvals and denials (+ and -)send mail as expected but the
original request (?) does not auto-cc drivers@ and asa@.

Comment 1

[Jacob Steenhagen]

I've actually noticed this w/attachment flags too.  In this product our review
requests are supposed to cc [e-mail] but if you don't specify a
person, then the list doesn't get the message.

In fact, this is starting to sound like something I've typed before and it was
determined that this happens because if a person isn't specified, then there's
no message to cc the list to.  Wonder if that was in a bug...

Comment 2

[Jacob Steenhagen]

This must've just been talked about in IRC as I can't find any mention of it in
the few queries I ran.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problem

Looks like the logic for whether to send an email erroneously required there to
be a requestee, which there isn't for requests which aren't specifically
requestable.  This logic makes a requestee optional if there's a CC list.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Checking in Bugzilla/Flag.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v  <--  Flag.pm
new revision: 1.14; previous revision: 1.13
done