1837892 - OpenPGP signatures should use a filename with an .asc suffix

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, enhancement)

Description

[Kai Engert [:KaiE:]]

When sending an email with an OpenPGP signature, Thunderbird sends:

Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Disposition: attachment; filename="OpenPGP_signature"

This seems inconsistent and causes trouble for some consumers.
I think it makes sense to add the .asc suffix to the filename for consistency.

Comment 1

[Kai Engert [:KaiE:]]

Patrick, do you remember if there was a specific reason to create it like this?

Comment 2

[Kai Engert [:KaiE:]]

Oh, it was me who had changed that...
It had a .asc extension in the past.

https://hg.mozilla.org/comm-central/rev/bf32f9306077#l2.15

Comment 3

[Kai Engert [:KaiE:]]

Attachment: Bug 1837892 - OpenPGP signatures should use a filename with an .asc suffix. r=mkmelin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/01255e7da373
OpenPGP signatures should use a filename with an .asc suffix. r=mkmelin

Comment 5

[Kai Engert [:KaiE:]]

Comment on attachment 9338547 [details]
Bug 1837892 - OpenPGP signatures should use a filename with an .asc suffix. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): 1628097
User impact if declined: trouble for software developers
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky): low, mir format consistency fix, restoring a format already used in the past

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9338547 [details]
Bug 1837892 - OpenPGP signatures should use a filename with an .asc suffix. r=mkmelin

[Triage Comment]
Approved for beta

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 115.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/655f00cebcf3