1837926 - Scripts containing Regexp with v flag breaks can't be parsed by parser worker

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Evaluate the following in the console

const re = /^\p{RGI_Emoji}$/v;
const str = '⚽'; // '\u26BD'
re.test(str); 
debugger

Expected results

Debugger pauses, and I can see inline previews for re and str

Actual results

Debugger pauses, but there's no inline previews, and tooltip does not work
I can see the following error in the browser console:

new SyntaxError("Invalid regular expression flag. (2:31)", "resource://devtools/client/debugger/dist/parser-worker.js", 46107)

---

We probably only need to update babel so v flag in RegExp can be parsed

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1826574

:dminor, since you are the author of the regressor, bug 1826574, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

No need for SM folks to have a look, that's a devtools specific issue

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1837926 - [devtools] Update babel/parser package. r=#devtools-reviewers.

This is needed to handle the new Regexp v flag.
I'm taking this as an opportunity to fix a couple issue in the bundle script.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1837926 - [devtools] Support new RegExp v flag in parser worker. r=#devtools-reviewers.

Add plugin-proposal-unicode-sets-regex babel plugin and use it.
Add a jest test for it.

Depends on D180675

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fed7871f2851
[devtools] Update babel/parser package. r=devtools-reviewers,ochameau.
https://hg.mozilla.org/integration/autoland/rev/24cab11905b4
[devtools] Support new RegExp v flag in parser worker. r=devtools-reviewers,ochameau.

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/fed7871f2851
https://hg.mozilla.org/mozilla-central/rev/24cab11905b4

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

== Change summary for alert #38687 (as of Wed, 14 Jun 2023 17:52:42 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
5%	damp custom.jsdebugger.open-large-minified-file.full-selection.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	18,084.39 -> 18,986.79
5%	damp custom.jsdebugger.open-large-minified-file.full-selection.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender	9,011.65 -> 9,449.18

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=38687