Closed Bug 1837946 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 40493 - Never force a break before when we're already inside the node.

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
116 Branch
Tracking Flags:
Tracking Status
firefox116 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 40493 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40493
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

Never force a break before when we're already inside the node.

When resuming a node after a fragmentainer break, ignore break-before
values, since we're obviously not before it anymore (since we're
inside). We used to end up in an infinite loop, until out of memory,
not making any fragmentation progress. This was caused by monolithic
content, which, when printing, may take up space on subsequent pages.
This tricked us into thinking that it was a good place to insert a
forced break before the node we were resuming, since we were not at the
beginning of the page.

Bug: 1451760
Change-Id: I3c3168478f0f23035abd10597927cee47c00730c
Reviewed-on: https://chromium-review.googlesource.com/4594563
WPT-Export-Revision: 20d79d93bee6d3a3bf4177f4419a376a35c05f5b

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL : 1

Chrome

TIMEOUT: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e1650ba7c9f3 [wpt PR 40493] - Never force a break before when we're already inside the node., a=testonly https://hg.mozilla.org/integration/autoland/rev/bb4be274612b [wpt PR 40493] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e1650ba7c9f3
https://hg.mozilla.org/mozilla-central/rev/bb4be274612b

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox116: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
You need to log in before you can comment on or make changes to this bug.