1837987 - Initialize without custom LibraryParameters field in C_INITIALIZE_ARGS

Status: RESOLVED FIXED

(NSS :: Libraries, enhancement)

Description

[fkrenzel]

Steps to reproduce:

pkcs11-tool -L --module libsoftokn3.so

Actual results:

Main C_Initialize(NULL) rv:CKR_ARGUMENTS_BAD
error: PKCS11 function C_Initialize failed: rv = CKR_ARGUMENTS_BAD (0x7)
Aborting.

Expected results:

If the arguments were provided by other means (e. g. enviromental variable, configuration file, default value) the initialization could be successfull.

Comment 1

[fkrenzel]

Attachment: Bug 1837987:Add means to provide library parameters to C_Initialize r=#nss-reviewers,rrelyea

Abstract:
NSS should be able to handle standard PKCS#11 CK_C_INITIALIZE_ARGS structure
without the LibraryParameters field. The library parameters should be provided
by other means.

Implementation:
With this commit the library parameters can be provided by the following means:

1. C_INITIALIZED_ARGS - lib params are included in LibraryParameters field
2. NSS_LIB_PARAMS - env. var. containing the lib. params.
3. NSS_LIB_PARAMS_FILE - env. var. pointion to a file with lib. params.
4. /etc/nss/params.config - default lib. param. file location
5. LIB_PARAM_DEFAULT - string ensureing the pressence at all times
   "configdir='' certPrefix='' keyPrefix='' secmod='' flags=noCertDB,noModDB"

The priority is given by the listed order

Comment 2

[John Schanck [:jschanck] (out of office Aug 11-18)]

Bob, can you take care of the clang-format regression here: https://treeherder.mozilla.org/jobs?repo=nss&revision=a64d9acdabc745d37724f9e8f335b4e02c84b92e&selectedTaskRun=89BJML5OQoyqgxZAElap4g.0

Comment 3

[Robert Relyea]

Yup. I'll verify that fkrenzel knows how to use the try server (I should have done a try push before pushing the patch myself).

Comment 4

[Dana Keeler (she/her) [:keeler]]

https://hg.mozilla.org/projects/nss/rev/a64d9acdabc745d37724f9e8f335b4e02c84b92e
https://hg.mozilla.org/projects/nss/rev/d336fc4b236bfa5f422e8ea6baaac12061892b03