1838045 - https://www.ing.com.au/securebanking/ no longer loads after bug 1834081

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Thomas Wisniewski [:twisniewski]]

As reported on webcompat.com, the site https://www.ing.com.au/securebanking/ no longer loads on pre-release builds, but does on Firefox 114 release (it can take a few seconds for the page to load). Mozregression pointed me to bug 1834081:

Bug 1834081 - Cache inline stylesheets regardless of shadow dom. r=mstange

Some pages (like Reddit) would have duplicate multi-kilobyte stylesheets
even at the top level.

Differential Revision: https://phabricator.services.mozilla.com/D178548

2023-06-12T12:32:26.230000: DEBUG : Did not find a branch, checking all integration branches
2023-06-12T12:32:26.233000: INFO : The bisection is done.
2023-06-12T12:32:26.234000: INFO : Stopped

I'm not sure how it would break the page, so I thought I would ask before diving into a deep diagnosis, in case it's a red herring.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1834081

:emilio, since you are the author of the regressor, bug 1834081, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

[Tracking Requested - why for this release]: We should avoid shipping this regression.

Comment 3

[Donal Meehan [:dmeehan]]

Tracking for Fx115
:emilio we can look at back the regressor out of beta if you don't have a fix. Could you triage the severity/priority?

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox115 (beta). However, the bug still isn't assigned.

:fgriffith, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Yikes, shut up BugBot.

Comment 6

[Frank Griffith Jr]

Thank you.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1838045 - Fix load event on cached inline style sheets. r=#style,#layout,mstange

Turns out we do fire load events on these (I thought they were only for
sheets with imports).

Simplify a bit some related code for links. Callers / observers need to
deal with SheetComplete being called sync anyways because of this:

https://searchfox.org/mozilla-central/rev/962a843f6d96283c45162c788dc72bf217fca7df/layout/style/Loader.cpp#1873

So this removes the need for SheetLoadData to be a runnable etc.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Yeah, let's disable the regressing bug on beta.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1838045 - Beta patch, disable regressing bug.

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9338906 [details]
Bug 1838045 - Beta patch, disable regressing bug.

Beta/Release Uplift Approval Request

• User impact if declined: comment 0, possibly other sites affected too.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Toggles back the pref introduced in the regressing bug to restore to pre-regression behavior.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 11

[Donal Meehan [:dmeehan]]

Comment on attachment 9338906 [details]
Bug 1838045 - Beta patch, disable regressing bug.

Approved for 115.0b5.

Comment 12

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e9d5e8a58cb2

Comment 13

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/66b9443a2c92
Backed out changeset e9d5e8a58cb2 (bug 1838045) for causing webrender test failures on beta

https://treeherder.mozilla.org/jobs?repo=mozilla-beta&selectedTaskRun=bQS5Idg9TKmHZ_3urIC5pQ.0&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Cdebug%2Cweb%2Cplatform%2Ctests%2Ctest-linux1804-64-qr%2Fdebug-web-platform-tests-crashtest%2Cwc&revision=5cacd05ad73e50693f7c5cfd239e806f0e58ec8f

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Okay let's backout the regressor directly instead I guess :)

Comment 15

[Donal Meehan [:dmeehan]]

I can back out the regressor (Bug 1834081) and a regression fix that landed afterwards (Bug 1834786) in the next beta push

Comment 16

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1838045 - Make <link rel=stylesheet> load event scheduling saner. r=smaug

The spec asks to post a task, see html.spec.whatwg.org/#update-a-style-block

What we were doing is quite crazy. Unifying the scheduling between
<style> and <link rel=stylesheet> on the patch above causes failures on
some mochitests.

Some of them aren't really related to these and are a pre-existing bug,
see bug 1838346.

Depends on D180840

Comment 17

[Donal Meehan [:dmeehan]]

Setting Fx115 to Fixed, the regressor bug 1834081 was backed out of beta

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10fc6f33d4ca
Fix load event on cached inline style sheets. r=mstange
https://hg.mozilla.org/integration/autoland/rev/775a6521f77b
Make <link rel=stylesheet> load event scheduling saner. r=smaug

Comment 19

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40553 for changes under testing/web-platform/tests

Comment 20

[Monica Chiorean]

Page https://www.ing.com.au/securebanking/ is still not loading on Win10x64 and MAC 12.6 using Firefox build 115.0b5 (20230613195413), should I wait for 115.0b6? Thank you.

Comment 21

[Emilio Cobos Álvarez (:emilio)]

Not sure, Donal?

Comment 22

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/10fc6f33d4ca
https://hg.mozilla.org/mozilla-central/rev/775a6521f77b

Comment 23

[Donal Meehan [:dmeehan]]

(In reply to Monica Chiorean from comment #20)

Page https://www.ing.com.au/securebanking/ is still not loading on Win10x64 and MAC 12.6 using Firefox build 115.0b5 (20230613195413), should I wait for 115.0b6? Thank you.

Yes, you should wait for 115.0b6 or test from the latest Treeherder builds.
The backout was pushed after the 115.0b5 build. 115.0b6 builds later today.

Comment 24

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 25

[Monica Chiorean]

Verified issue as fixed on Win10/Mac 12.6/Ubuntu 20.04 using FF builds 115.0b6(20230615175802) and 116.0a1(20230616094829).