1838056 - Embedded migration wizard never exits the loading state

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Bug 1823537 moved the registration of the MigrationWizard JSWindowActor pair into MigrationUtils from BrowserGlue. This makes it so that the wizard can be used properly in the scenario where BrowserGlue hasn't yet had a chance to run (which is the case when we're showing the migration wizard on startup).

This, however, means that the actors aren't being registered unless MigrationUtils is loaded, which is no longer the case having moved the registration outside of BrowserGlue.

This means that the embedded migration wizard in about:welcome (and the spotlight experience in bug 1837051) will not work until that module loads and the registration occurs.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1838056 - Make sure to load MigrationUtils in BrowserGlue. r?niklas!

Bug 1823537 moved the registration of the MigrationWizard JSWindowActor pair
into MigrationUtils from BrowserGlue. This makes it so that the wizard can
be used properly in the scenario where BrowserGlue hasn't yet had a chance
to run (which is the case when we're showing the migration wizard on startup).

This, however, means that the actors aren't being registered unless MigrationUtils
is loaded, which is no longer the case having moved the registration outside of
BrowserGlue.

This means that the embedded migration wizard in about:welcome (and the spotlight
experience in bug 1837051) will not work until that module loads and the
registration occurs.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

(Our automated testing didn't pick this up because our mochitest-browser test harness loads MigrationUtils, which achieves the desired registration)

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1823537

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90a2e5f4b324
Make sure to load MigrationUtils in BrowserGlue. r=niklas

Comment 5

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser_startup.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup.js | should have no unexpected modules loaded before profile selection - Got 1, expected +0

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c065a7c4f8c0
Make sure to load MigrationUtils in BrowserGlue. r=niklas

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c065a7c4f8c0

Comment 8

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible using the latest Firefox Beta 116.0b8 (Build ID: 20230720200012) installed on Windows 10 x64, macOS 13.4.1, and Linux Mint 21.1. I can confirm that all the available data is successfully imported if the "Import" button from the "Embedded Import Wizard" Onboarding screen is clicked.