1838106 - WPT css/css-transforms/animation/rotate-composition.html fails in Firefox

Status: RESOLVED FIXED

(Core :: CSS Transitions and Animations, defect)

Description

[Daniel Holbert [:dholbert] (PTO until 2/24)]

We fail 11 subtests in this WPT:
https://wpt.fyi/results/css/css-transforms/animation/rotate-composition.html

Direct link to test:
http://wpt.live/css/css-transforms/animation/rotate-composition.html

All the failures seem to be due to us getting a different angle vs. what the test expects. E.g. 10deg vs 50deg in the first failure:

!EQ("0.27 0.53 0.8 10deg",
    "0.27 0.53 0.8 50deg")

Comment 1

[Boris Chiou [:boris]]

Attachment: Bug 1838106 - Use approx_eq() to compare two direction vectors.

Basically, if two normalized direction vectors are the same, we do
interpolation on the angle only. However, after normalization, there may
be some differences because of the floating-point precision, even though
these two vectors have the same direction. Therefore we have to add an
epsilon to compare these two vectors.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e459a98f336c
Use approx_eq() to compare two direction vectors. r=dholbert

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e459a98f336c