1838109 - OpenPGP key change expiration dialog size and layout issues

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Magnus Melin [:mkmelin]]

Attachment: expiry-before.png

Buttons misplaced out of screen, and there's a a huge empty area on the right.
The months selector will also not properly show values, if opened a few times.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1838109 - OpenPGP key change expiration dialog size and layout issues. r=freaktechnik,kaie

For testing: in the OpenPGP key manager, open a key you own. Click "Change Expiration Date"

There were multiple layout issues, dialog size issues pushing buttons out of the screen,
and some problem with the dropdown not actually showing the values.

In addition, the time calculations were somewhat inaccurate.

Converted the dialog to HTML, and using more accurate calculations + show time in a more readable fashion: up to 24 months as months, then as years.
There were some limitations on how to change expiry to something shorter than you had, but I don't see much reason for that - and previously it
could also be worked around by setting not expiring, and then setting a shorter date. I think there are reasons someone may want to shorten the
expiry time - whether that will take effect "at large" is not something we can guarantee.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: expiry-after.png

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 1838109 - OpenPGP key details dialog font size and layout fix. r=#thunderbird-front-end-reviewers,kaie

Fix font size in the dialog.
Size it properly - some buttons were off screen especially when opening from account settings.

Found lots of dead css.

Comment 4

[Phabricator Automation]

Comment on attachment 9338763 [details]
Bug 1838109 - OpenPGP key details dialog font size and layout fix. r=#thunderbird-front-end-reviewers,kaie

Revision D180757 was moved to bug 1793708. Setting attachment 9338763 [details] to obsolete.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3be47d0dd710
OpenPGP key change expiration dialog size and layout issues. r=freaktechnik

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9338758 [details]
Bug 1838109 - OpenPGP key change expiration dialog size and layout issues. r=freaktechnik,kaie

[Approval Request Comment]
Regression caused by (bug #): unclear
User impact if declined: UI issues
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): pretty safe

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9338758 [details]
Bug 1838109 - OpenPGP key change expiration dialog size and layout issues. r=freaktechnik,kaie

[Triage Comment]
Approved for beta

Comment 8

[Daniel Darnell [:dandarnell]]

Thunderbird 115.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/d8d07f09250a

Comment 9

[Kai Engert [:KaiE:]]

(In reply to Magnus Melin [:mkmelin] from comment #1)

using more accurate calculations + show time in a more readable fashion: up to 24 months as months, then as years.

Thank you!