1838122 - Deduplicating FormAutoCompleteResult implementations

Status: RESOLVED FIXED

(Toolkit :: Form Manager, task, P1)

Description

[Sergey Galich [:serg]]

There are 2 similar class FormAutoCompleteResult defined in toolkit/components/satchel/FormAutoComplete.sys.mjs and toolkit/components/satchel/FormAutoCompleteResult.sys.mjs plus some logic to split and merge these results by wrapping one into another. This bug is to keep only one implementation of the FormAutoCompleteResult that can show both Form History results and Fixed Entries list (datalist or search suggestions or other integrations that add to the form history).

Comment 1

[Sergey Galich [:serg]]

Attachment: Bug 1838122 - Deduplicating FormAutoCompleteResult implementations r=#credential-management-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f0a28ae1bde
Deduplicating FormAutoCompleteResult implementations r=credential-management-reviewers,search-reviewers,issammani,Standard8

Comment 3

[Serban Stanca [:SerbanS]]

Backed out for causing bc failures in nsAutoCompleteController.cpp.

• Backout link
• Push with failures
• Failure Log
• Failure line: Assertion failure: mSearchesOngoing > 0 && mSearches.Contains(aSearch), at /builds/worker/checkouts/gecko/toolkit/components/autocomplete/nsAutoCompleteController.cpp:810

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68bc85e67303
Deduplicating FormAutoCompleteResult implementations r=credential-management-reviewers,search-reviewers,issammani,Standard8

Comment 5

[Iulian Moraru]

Backed out for causing mochitest assertion failures on nsAutoCompleteController.cpp.
So far, this seems to only happen on Linux 18.04 x64 WebRender debug.

• Push with failures

• Failure log

• Backout link

[task 2023-07-14T07:09:04.485Z] 07:09:04     INFO - TEST-START | browser/components/customizableui/test/browser_940307_panel_click_closure_handling.js
[task 2023-07-14T07:09:04.805Z] 07:09:04     INFO - GECKO(1571) | [WARN  webrender::renderer::init] asking to enable_gpu_markers but no supporting extension was found
[task 2023-07-14T07:09:04.919Z] 07:09:04     INFO - GECKO(1571) | [Parent 1571, Main Thread] WARNING: NS_ENSURE_TRUE(mPresShell) failed: file /builds/worker/checkouts/gecko/layout/generic/nsFrameSelection.cpp:1711
[task 2023-07-14T07:09:05.249Z] 07:09:05     INFO - GECKO(1571) | Assertion failure: mSearchesOngoing > 0 && mSearches.Contains(aSearch), at /builds/worker/checkouts/gecko/toolkit/components/autocomplete/nsAutoCompleteController.cpp:810
[task 2023-07-14T07:09:05.252Z] 07:09:05     INFO -  Initializing stack-fixing for the first stack frame, this may take a while...
[task 2023-07-14T07:09:14.731Z] 07:09:14     INFO - GECKO(1571) | #01: nsAutoCompleteController::OnSearchResult(nsIAutoCompleteSearch*, nsIAutoCompleteResult*) [toolkit/components/autocomplete/nsAutoCompleteController.cpp:810]
[task 2023-07-14T07:09:14.732Z] 07:09:14     INFO - GECKO(1571) | #02: {virtual override thunk({offset(-8)}, nsAutoCompleteController::OnSearchResult(nsIAutoCompleteSearch*, nsIAutoCompleteResult*))} [toolkit/components/autocomplete/nsAutoCompleteController.cpp:0]
[task 2023-07-14T07:09:14.733Z] 07:09:14     INFO - GECKO(1571) | #03: ??? [/builds/worker/workspace/build/application/firefox/libxul.so + 0x4294a92]
[task 2023-07-14T07:09:14.734Z] 07:09:14     INFO - GECKO(1571) | #04: CallMethodHelper::Call() [js/xpconnect/src/XPCWrappedNative.cpp:1180]
[task 2023-07-14T07:09:14.735Z] 07:09:14     INFO - GECKO(1571) | #05: XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode) [js/xpconnect/src/XPCWrappedNative.cpp:1126]
[task 2023-07-14T07:09:14.736Z] 07:09:14     INFO - GECKO(1571) | #06: XPC_WN_CallMethod(JSContext*, unsigned int, JS::Value*) [js/xpconnect/src/XPCWrappedNativeJSOps.cpp:966]
[task 2023-07-14T07:09:14.737Z] 07:09:14     INFO - GECKO(1571) | #07: CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), js::CallReason, JS::CallArgs const&) [js/src/vm/Interpreter.cpp:486]
[task 2023-07-14T07:09:14.737Z] 07:09:14     INFO - GECKO(1571) | #08: js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [js/src/vm/Interpreter.cpp:580]
[task 2023-07-14T07:09:14.738Z] 07:09:14     INFO - GECKO(1571) | #09: js::Interpret(JSContext*, js::RunState&) [js/src/vm/Interpreter.cpp:0]
[task 2023-07-14T07:09:14.738Z] 07:09:14     INFO - GECKO(1571) | #10: js::RunScript(JSContext*, js::RunState&) [js/src/vm/Interpreter.cpp:458]
[task 2023-07-14T07:09:14.739Z] 07:09:14     INFO - GECKO(1571) | #11: js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [js/src/vm/Interpreter.cpp:612]
[task 2023-07-14T07:09:14.739Z] 07:09:14     INFO - GECKO(1571) | #12: js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) [js/src/vm/Interpreter.cpp:679]
[task 2023-07-14T07:09:14.740Z] 07:09:14     INFO - GECKO(1571) | #13: js::CallSelfHostedFunction(JSContext*, JS::Handle<js::PropertyName*>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>) [js/src/vm/SelfHosting.cpp:1500]
[task 2023-07-14T07:09:14.740Z] 07:09:14     INFO - GECKO(1571) | #14: js::jit::InterpretResume(JSContext*, JS::Handle<JSObject*>, JS::Value*, JS::MutableHandle<JS::Value>) [js/src/jit/VMFunctions.cpp:1040]
[task 2023-07-14T07:09:14.741Z] 07:09:14     INFO - GECKO(1571) | #15: ??? (???:???)
[task 2023-07-14T07:09:14.741Z] 07:09:14     INFO - GECKO(1571) | ExceptionHandler::GenerateDump cloned child 2031
[task 2023-07-14T07:09:14.742Z] 07:09:14     INFO - GECKO(1571) | ExceptionHandler::SendContinueSignalToChild sent continue signal to child
[task 2023-07-14T07:09:14.742Z] 07:09:14     INFO - GECKO(1571) | ExceptionHandler::WaitForContinueSignal waiting for continue signal...
[task 2023-07-14T07:09:14.743Z] 07:09:14     INFO - GECKO(1571) | [Child 1869, IPC I/O Child] WARNING: [38352FE878DE079D.9A84E0CBCB15A11C]: Ignoring message 'EVENT_MESSAGE' to peer 1.1 due to a missing broker: file /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp:352
[task 2023-07-14T07:09:14.743Z] 07:09:14     INFO - GECKO(1571) | [Child 1869, IPC I/O Child] WARNING: [38352FE878DE079D.9A84E0CBCB15A11C]: Ignoring message 'EVENT_MESSAGE' to peer 1.1 due to a missing broker: file /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp:352
[task 2023-07-14T07:09:14.744Z] 07:09:14     INFO - GECKO(1571) | [Child 1869, IPC I/O Child] WARNING: [38352FE878DE079D.9A84E0CBCB15A11C]: Ignoring message 'EVENT_MESSAGE' to peer 1.1 due to a missing broker: file /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp:352
[task 2023-07-14T07:09:14.744Z] 07:09:14     INFO - GECKO(1571) | Exiting due to channel error.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f1b41217256
Deduplicating FormAutoCompleteResult implementations r=credential-management-reviewers,search-reviewers,issammani,Standard8

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8f1b41217256