Closed Bug 1838214 Opened 6 months ago Closed 5 months ago

Include the log level in mach human/terminal log output

Categories

(Firefox Build System :: Mach Core, enhancement, P3)

Product:
Firefox Build System
Component:
Mach Core
Type:
enhancement

Tracking

(firefox116 fixed)

Status:
RESOLVED FIXED
Milestone:
116 Branch
Tracking Flags:
Tracking Status
firefox116 --- fixed

People

(Reporter: afranchuk, Assigned: afranchuk)

References

Details

Attachments

(1 file)

Bug 1838214 - Include the log level in mach human/terminal log output r=ahochheiden,glandium
48 bytes, text/x-phabricator-request
Details | Review

The StructuredHumanFormatter and StructuredTerminalFormatter only display the message time offset and message. The omission of the log level can sometimes be confusing for users. Bug 1835274 discusses how e.g. mach vendor rust didn't make the errors clear, and they weren't always the last lines logged on failure.

Including a minimal indication of the log level would help avoid these confusing scenarios.

This includes the log level as a single character (with a space, adding 2 total characters to log
lines). It is colored when there is a terminal present.

Status: NEW → ASSIGNED
Pushed by afranchuk@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3be43da6c87b
Include the log level in mach human/terminal log output r=ahochheiden,ahal

https://hg.mozilla.org/mozilla-central/rev/3be43da6c87b

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox116: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
You need to log in before you can comment on or make changes to this bug.