1838238 - Missing responseCompleted events for redirected document requests

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P1)

Description

[Julian Descottes [:jdescottes]]

STRs:

• subscribe to network.responseCompleted
• trigger a navigation to https://google.com

ER:

Should get network.responseCompleted events for https://google.com/ and for https://www.google.com/

AR:

Events are missing

Comment 1

[Julian Descottes [:jdescottes]]

The issue is that for redirects we are trying to translate a browsingContext which is gone to a tabmanager id. This fails and we fail to emit the event.
I think the comment at https://searchfox.org/mozilla-central/rev/962a843f6d96283c45162c788dc72bf217fca7df/remote/shared/listeners/NetworkEventRecord.sys.mjs#280-289 is wrong. We should always be able to trust the tabmanager id to remain identical for a navigation.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1838238 - [bidi] Fix responseCompleted for redirects with browsing context swaps

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1838238 - [wdspec] Add wdspec network test for navigation and redirect with COOP

Depends on D180854

Comment 4

[Julian Descottes [:jdescottes]]

In case we want to fix this, patches are attached, we'll triage this later.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/313cfd6c08ee
[bidi] Fix responseCompleted for redirects with browsing context swaps r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/18cd337d0ef2
[wdspec] Add wdspec network test for navigation and redirect with COOP r=webdriver-reviewers,whimboo

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40576 for changes under testing/web-platform/tests

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/313cfd6c08ee
https://hg.mozilla.org/mozilla-central/rev/18cd337d0ef2

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 10

[Julian Descottes [:jdescottes]]

(we forgot priorities points and flags on this one)