Closed Bug 1838238 Opened 1 year ago Closed 1 year ago

Missing responseCompleted events for redirected document requests

Categories

(Remote Protocol :: WebDriver BiDi, defect, P1)

defect
Points:
2

Tracking

(firefox116 fixed)

RESOLVED FIXED
116 Branch
Tracking Status
firefox116 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

(Whiteboard: [webdriver:m7] [webdriver:relnote])

Attachments

(2 files)

STRs:

  • subscribe to network.responseCompleted
  • trigger a navigation to https://google.com

ER:

Should get network.responseCompleted events for https://google.com/ and for https://www.google.com/

AR:

Events are missing

The issue is that for redirects we are trying to translate a browsingContext which is gone to a tabmanager id. This fails and we fail to emit the event.
I think the comment at https://searchfox.org/mozilla-central/rev/962a843f6d96283c45162c788dc72bf217fca7df/remote/shared/listeners/NetworkEventRecord.sys.mjs#280-289 is wrong. We should always be able to trust the tabmanager id to remain identical for a navigation.

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED

In case we want to fix this, patches are attached, we'll triage this later.

Assignee: jdescottes → nobody
Status: ASSIGNED → NEW
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/313cfd6c08ee
[bidi] Fix responseCompleted for redirects with browsing context swaps r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/18cd337d0ef2
[wdspec] Add wdspec network test for navigation and redirect with COOP r=webdriver-reviewers,whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40576 for changes under testing/web-platform/tests
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
Upstream PR was closed without merging
Upstream PR merged by moz-wptsync-bot

(we forgot priorities points and flags on this one)

Severity: -- → S3
Points: --- → 2
Priority: -- → P1
Whiteboard: [webdriver:m7] [webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: