1838240 - Migrate these probes to glean: DNS_LOOKUP_TIME, DNS_RENEWAL_TIME, DNS_RENEWAL_TIME_FOR_TTL, DNS_FAILED_LOOKUP_TIME

Status: RESOLVED FIXED

(Core :: Networking: DNS, task, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

We need to see how common bug 1664492 is on Fenix.
To do that we need telemetry, so we need to convert DNS_LOOKUP_TIME to glean.

Comment 1

[Andrew Creskey [:acreskey]]

Denis added dns_lookup_time to the pageload event in Bug 1834774 (has made its way to Beta so far).

I made a variation of the pageload event query that compares any of the pageload event metrics, Fenix to Desktop.
This is dns_lookup_time Fenix/Desktop

In Beta, the overall android DNS lookup times look comparable to desktop, with some very slow ones at the tail (but a bit better than Desktop).

I'll add a new glean and geckoview-exposed probe since we'll want this for any experiments.

Comment 2

[Andrew Creskey [:acreskey]]

We do have HTTP_PAGE_DNS_LOOKUP_TIME being channelled through geckoview_stream

Visible here:
https://glam.telemetry.mozilla.org/fenix/probe/network_dns_end/explore?aggType=avg&app_id=release&currentPage=1
But that's only DNS lookup time for the top-level document.

I'm going to make a new glean probe and mirror DNS_LOOKUP_TIME to it.

Comment 3

[Andrew Creskey [:acreskey]]

Attachment: network.dns_lookup_time.md

Edit -- sorry, I'm going to change this request and migrate additional DNS probes to glean.

Comment 4

[Andrew Creskey [:acreskey]]

Attachment: Bug 1838240 - Migrate these probes to glean: DNS_LOOKUP_TIME, DNS_RENEWAL_TIME, DNS_RENEWAL_TIME_FOR_TTL, DNS_FAILED_LOOKUP_TIME r=#necko-reviewers

We want to collect DNS lookup times on Fenix as there is potential for improvement.

Comment 5

[Andrew Creskey [:acreskey]]

Comment on attachment 9340168 [details]
network.dns_lookup_time.md

!! Reminder: it is your responsibility to complete and check the correctness of
!! this automatically-generated request skeleton before requesting Data
!! Collection Review. See https://wiki.mozilla.org/Data_Collection for details.

DATA REVIEW REQUEST
1. What questions will you answer with this data?

How long do users wait for DNS requests to complete (for each possible outcome)?

We are migrating from the legacy probes,
```
DNS_LOOKUP_TIME
DNS_RENEWAL_TIME
DNS_RENEWAL_TIME_FOR_TTL
DNS_FAILED_LOOKUP_TIME
```
so that we can also collect on Fenix.

2. Why does Mozilla need to answer these questions? Are there benefits for users?
   Do we need this information to address product or business requirements?

DNS lookup times directly affect pageload times.
So any improvements (or regressions) are visible to users.
We need this data to inform our choices on future DNS improvements.

In order to guarantee the performance of our products, it is vital to monitor
real-world installs used by real-world users.

3. What alternative methods did you consider to answer these questions?
   Why were they not sufficient?

Lab environment tests do not measure the performance that users experience due to the lack of network and host diversity.

4. Can current instrumentation answer these questions?

No.

5. List all proposed measurements and indicate the category of data collection for each
   measurement, using the Firefox data collection categories found on the Mozilla wiki.

Measurement Name | Measurement Description | Data Collection Category | Tracking Bug
---------------- | ----------------------- | ------------------------ | ------------
`networking.dns_lookup_time` | Time for a successful DNS resolution (msec). | technical | https://bugzilla.mozilla.org/show_bug.cgi?id=1838240
`networking.dns_renewal_time` | Time for a renewed DNS OS resolution (msec). | technical | https://bugzilla.mozilla.org/show_bug.cgi?id=1838240
`networking.dns_renewal_time_for_ttl` | Time for a DNS OS resolution (msec) used to get TTL. | technical | https://bugzilla.mozilla.org/show_bug.cgi?id=1838240
`networking.dns_failed_lookup_time` | Time for an unsuccessful DNS OS resolution (msec). | technical | https://bugzilla.mozilla.org/show_bug.cgi?id=1838240


6. Please provide a link to the documentation for this data collection which
   describes the ultimate data set in a public, complete, and accurate way.

This collection is Glean so is documented
[in the Glean Dictionary](https://dictionary.telemetry.mozilla.org).

7. How long will this data be collected?

This collection will be collected permanently.
[e-mail], [e-mail] will be responsible for the permanent collections.

8. What populations will you measure?

All channels, countries, and locales. No filters.

9. If this data collection is default on, what is the opt-out mechanism for users?

These collections are Glean. The opt-out can be found in the product's preferences.

10. Please provide a general description of how you will analyze this data.

The data will be viewed through glam.
More refined queries may be made to investigate the specifics.

11. Where do you intend to share the results of your analysis?

Internal monitoring (GLAM, Redash, Looker, etc.).

12. Is there a third-party tool (i.e. not Telemetry) that you
    are proposing to use for this data collection?

No.

Comment 6

[Andrew Creskey [:acreskey]]

Attachment: migrate_dns_probes.md

Please see this attached request for data review.

Comment 7

[Chris H-C :chutten]

Comment on attachment 9340297 [details]
migrate_dns_probes.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, [e-mail] and [e-mail] are responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ca20b10728e
Migrate these probes to glean: DNS_LOOKUP_TIME, DNS_RENEWAL_TIME, DNS_RENEWAL_TIME_FOR_TTL, DNS_FAILED_LOOKUP_TIME  r=necko-reviewers,valentin

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3ca20b10728e