1838262 - `getComputedStyle()` does not return values for Custom Highlight API

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Description

[Jan Jaeschke [:jjaschke]]

Calling getComputedStyle() for a highlight curently does not return any values, which is the reason these WPTs fail.

Comment 1

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1838262, part 2: Implemented `getComputedStyle()` for custom highlight api. r=emilio!,#dom-core

Comment 2

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1838262, part 3: Removed `ServoStyleSet::ProbeHighlightPseudoElementStyle()`. r=emilio!,#dom-core

Depends on D183773

Comment 3

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1838262, part 1: Changed expected WPT results for `getComputedStyle()` in custom highlight API tests. r=emilio!

As per [0], [1] and [2], getComputedStyle() should not return the
default style when the pseudo is invalid.
Instead, an empty style should be returned.

[0] https://drafts.csswg.org/cssom/#extensions-to-the-window-interface
[1] https://github.com/w3c/csswg-drafts/issues/6501
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=1726396

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c145766032f
part 1: Changed expected WPT results for `getComputedStyle()` in custom highlight API tests. r=emilio
https://hg.mozilla.org/integration/autoland/rev/c7f3f28e7882
part 2: Implemented `getComputedStyle()` for custom highlight api. r=emilio
https://hg.mozilla.org/integration/autoland/rev/7b994721e8fb
part 3: Removed `ServoStyleSet::ProbeHighlightPseudoElementStyle()`. r=emilio

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41244 for changes under testing/web-platform/tests

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/1c145766032f
https://hg.mozilla.org/mozilla-central/rev/c7f3f28e7882
https://hg.mozilla.org/mozilla-central/rev/7b994721e8fb

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot