Closed Bug 1838403 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 40542 - WebSocket: add wpt for sending 50 65K messages

Categories

(Core :: Networking: WebSockets, task, P4)

Product:
Core
Component:
Networking: WebSockets
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
116 Branch
Tracking Flags:
Tracking Status
firefox116 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 40542 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40542
Details from upstream follow.

Adam Rice <ricea@chromium.org> wrote:

WebSocket: add wpt for sending 50 65K messages

http://crrev/c/3311025 introduced a bug when sending messages a multiple
of 65536 bytes in size over a connection with backpressure. This was
fixed in http://crrev/c/3404081 in January 2022, however no repro test
was added at that time.

Add a wpt to repro the issue and stop it happening again.

BUG=1454078

Change-Id: Icdc1dab66e58bab6eaabec84c0f53d5f17ca28e8
Reviewed-on: https://chromium-review.googlesource.com/4612732
WPT-Export-Revision: c8da4547fcceac4f8454c0b33f68698fce9bc434

Component: web-platform-tests → Networking: WebSockets
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 12 tests and 1 subtests

Status Summary

Firefox

OK : 8[Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-opt, GitHub] 11[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-debug]
PASS : 7
FAIL : 1[Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-opt, GitHub] 4[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-debug]
TIMEOUT: 2[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-debug] 8[Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-opt, GitHub]

Chrome

OK : 8
PASS : 7
FAIL : 1
TIMEOUT: 8

Safari

OK : 8
PASS : 7
FAIL : 1
TIMEOUT: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /websockets/send-many-64K-messages-with-backpressure.any.serviceworker.html [wpt.fyi]
    • sending 50 messages of size 65536 with backpressure applied should not hang: FAIL (Chrome: FAIL, Safari: FAIL)
  • /websockets/send-many-64K-messages-with-backpressure.any.worker.html?wpt_flags=h2 [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-debug], TIMEOUT [Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-opt, GitHub] (Chrome: TIMEOUT, Safari: TIMEOUT)
    • sending 50 messages of size 65536 with backpressure applied should not hang: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-debug], TIMEOUT [Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-opt, GitHub] (Chrome: TIMEOUT, Safari: TIMEOUT)
  • /websockets/send-many-64K-messages-with-backpressure.any.serviceworker.html?wpt_flags=h2 [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
    • sending 50 messages of size 65536 with backpressure applied should not hang: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
  • /websockets/send-many-64K-messages-with-backpressure.any.html?wpt_flags=h2 [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-debug], TIMEOUT [Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-opt, GitHub] (Chrome: TIMEOUT, Safari: TIMEOUT)
    • sending 50 messages of size 65536 with backpressure applied should not hang: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-debug], TIMEOUT [Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-opt, GitHub] (Chrome: TIMEOUT, Safari: TIMEOUT)
  • /websockets/send-many-64K-messages-with-backpressure.any.sharedworker.html?wpt_flags=h2 [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-debug], TIMEOUT [Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-opt, GitHub] (Chrome: TIMEOUT, Safari: TIMEOUT)
    • sending 50 messages of size 65536 with backpressure applied should not hang: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-debug], TIMEOUT [Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-opt, GitHub] (Chrome: TIMEOUT, Safari: TIMEOUT)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f23b60295b97 [wpt PR 40542] - WebSocket: add wpt for sending 50 65K messages, a=testonly https://hg.mozilla.org/integration/autoland/rev/0f7eeec31cd3 [wpt PR 40542] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f23b60295b97
https://hg.mozilla.org/mozilla-central/rev/0f7eeec31cd3

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox116: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
You need to log in before you can comment on or make changes to this bug.