1838453 - Crash in [@ core::result::unwrap_failed | glean_core::dispatcher::impl$1::block_on_queue_timeout::closure$0]

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

350 crashes from as many installations of Firefox 114.0.x on Windows. Crash signature not observed for previous versions.

Crash report: https://crash-stats.mozilla.org/report/index/111ae3cd-02b8-4f74-865a-c105a0230614

MOZ_CRASH Reason: (worker) Can't send message on single-use channel: "SendError(..)"

Top 10 frames of crashing thread:

0  xul.dll  MOZ_Crash  mfbt/Assertions.h:261
0  xul.dll  RustMozCrash  mozglue/static/rust/wrappers.cpp:17
1  xul.dll  mozglue_static::panic_hook  mozglue/static/rust/lib.rs:96
2  xul.dll  core::ops::function::Fn::call<void   /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/core/src/ops/function.rs:166
3  xul.dll  alloc::boxed::impl$47::call  library/alloc/src/boxed.rs:2001
3  xul.dll  std::panicking::rust_panic_with_hook  library/std/src/panicking.rs:696
4  xul.dll  std::panicking::begin_panic_handler::closure$0  library/std/src/panicking.rs:583
5  xul.dll  std::sys_common::backtrace::__rust_end_short_backtrace<std::panicking::begin_panic_handler::closure_env$0, never$>  library/std/src/sys_common/backtrace.rs:150
6  xul.dll  std::panicking::begin_panic_handler  library/std/src/panicking.rs:579
7  xul.dll  core::panicking::panic_fmt  library/core/src/panicking.rs:64

Any idea what started this?

Comment 1

[Jan-Erik Rediger [:janerik]]

Interesting. In the implementation back then we initially protected against this, but simplified it later on.
Looks like it happens often enough that we should do something about it.

It's unfortunate we didn't see this earlier.

Comment 2

[BMO Github Automation]

Attachment: [mozilla/glean] Bug 1838453 - Shutdown timeout: Gracefully handle the waiting thread going away (#2503)

Comment 3

[Jan-Erik Rediger [:janerik]]

badboy merged PR #2503: "Bug 1838453 - Shutdown timeout: Gracefully handle the waiting thread going away" in 2439105.

Comment 4

[Jan-Erik Rediger [:janerik]]

This lingered around, but I think we fixed it? At least release looks fine; it wasn't backported to 115 (esr).