1838468 - Warning spam from !Theme::ThemeSupportsWidget(aFrame->PresContext(), aFrame, aAppearance)

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Andrew McCreight [:mccr8] (PTO until 12-2)]

In a recent Linux debug try run I did, the second most frequent source of NS_WARNING spam was:

WARNING: '!Theme::ThemeSupportsWidget(aFrame->PresContext(), aFrame, aAppearance)', file widget/gtk/nsNativeThemeGTK.cpp:1085

There were almost 390,000 instances of this.

Looking at one log, there are two individual tests where the warning was spammed around 200 times, and not occurring in other ones:

browser/base/content/test/plugins/browser_private_browsing_eme_persistent_state.js
browser/components/uitour/test/browser_UITour_private_browsing.js

Could this warning be silenced or somehow changed so we only get it once instead of over and over again?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1817396

Comment 2

[Andrew McCreight [:mccr8] (PTO until 12-2)]

This only affects log spam in debug builds, so there's no need to backport anything.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Yeah the fact that it only happens in PB mode was a good hint.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1838468 - Remove noisy warning. r=mccr8

Usually, this warning points at a problem (we're rendering a native
widget in light mode in a page where we should render it in dark mode).

However there are cases where we do this legitimately, for example for
the -moz-window-titlebar appearance. We render the light titlebar behind
the tabs to be able to render shadows appropriately.

We could probably only warn in some cases but honestly I don't think
that is particularly appealing, so let's remove it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b936cb4476b9
Remove noisy warning. r=mccr8

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b936cb4476b9

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Can we take this on ESR115 to cut down on the logspam there for the next year+? :-)

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9339106 [details]
Bug 1838468 - Remove noisy warning. r=mccr8

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: comment 7
• User impact if declined: none
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): debug-only

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9339106 [details]
Bug 1838468 - Remove noisy warning. r=mccr8

Approved for 115.0esr.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr115/rev/7edd8b2164b4