1838473 - Address bar 2-lines layout (for small windows) doesn't show the URL anymore

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Gian-Carlo Pascutto [:gcp]]

Very recent regression, current Nightly, Ubuntu 22.04 LTS on Linux, X11 + KDE

1. Click the address bar (any tab, including new ones)
2. See a list of sites but no URL
3. Click a site
4. End up on a random subsection of said site

Not seeing the URL makes it impossible to determine what the actual destination of the suggested sites is.

For example, I have a history suggestion "Reddit", but clicking this won't bring me to the reddit frontpage, but to whatever subsection I've been visiting a lot recently (as is actually the case now, one that's been closed due to protests, whereas if the link would have visited the actual frontpage it'd have worked).

Same issue exists with other news sites, where clicking the address bar feels like playing Chatroulette.

Comment 1

[Gian-Carlo Pascutto [:gcp]]

Attachment: image_720.png

Comment 2

[Mark Banner (:standard8)]

I've not been able to reproduce this yet on the latest nightly on Mac.

It might be useful to know what your settings are under "Privacy & Security" -> "Address Bar — Firefox Suggest".

Maybe also "Search" -> "Search Suggestions" though I don't think those ones would affect this.

Comment 3

[Gian-Carlo Pascutto [:gcp]]

Attachment: settings.png

Comment 4

[Marco Bonardo [:mak]]

It looks like something broke the urlbar 2-lines layout.
Looking for a regression window.

Comment 5

[Marco Bonardo [:mak]]

[Tracking Requested - why for this release]: broken address bar

Comment 6

[Marco Bonardo [:mak]]

Dale, could you please have a look?

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1837815

Comment 8

[Dale Harvey (:daleharvey)]

Attachment: Bug 1838473 - Ensure urlbar rows without rich icons can wrap. r=adw

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7524a63fd9e8
Ensure urlbar rows without rich icons can wrap. r=adw,desktop-theme-reviewers,dao

Comment 10

[Dale Harvey (:daleharvey)]

clearing needinfo

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/7524a63fd9e8

Comment 12

[Dale Harvey (:daleharvey)]

[Tracking Requested - why for this release]:

Comment 13

[Dale Harvey (:daleharvey)]

Comment on attachment 9339169 [details]
Bug 1838473 - Ensure urlbar rows without rich icons can wrap. r=adw

Beta/Release Uplift Approval Request

• User impact if declined: Users enrolled in experiment may have urlbar not display some results correctly.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small CSS change that has been verified in nightly
• String changes made/needed:
• Is Android affected?: No

Comment 14

[Dale Harvey (:daleharvey)]

We are looking to run an experiment with Rich Suggestions enabled in 115

Comment 15

[Donal Meehan [:dmeehan]]

Comment on attachment 9339169 [details]
Bug 1838473 - Ensure urlbar rows without rich icons can wrap. r=adw

Approved for 115.0b9.
Next week is RC for Fx115, rejecting release uplift approval

Comment 16

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/09c659f91f5c

Comment 17

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-06-14 Nightly build on Windows 10.
Verified as fixed on Firefox 115.0b9(build ID: 20230622161221) and Nightly 116.0a1(build ID: 20230623092529) on Windows 10, macOS 12, Ubuntu 22.
Address Bar now displays the URL's of corresponding websites when the browser window is resized(small).