Closed Bug 1838528 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 40550 - [GridNG] Updates to grid-repeat-max-width-001.html

Categories

(Core :: Layout: Grid, task, P4)

task

Tracking

()

RESOLVED FIXED
119 Branch
Tracking Status
firefox119 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 40550 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40550
Details from upstream follow.

Kurt Catti-Schmidt <kschmi@microsoft.com> wrote:

[GridNG] Updates to grid-repeat-max-width-001.html

This test is validating the auto-repeat counts of a grid under certain
conditions. There is an issue with its method of verification, which
is matching a green square. This will never happen, due to the
max-width: 200px being set on the grid - the grid will stretch to
200px due to this and never match the green square.

This update verifies a single repeat was computed via Javascript, and
then sets the width to min-content (which computes to 0), and the
grid-items overflow to render a green square. If two repeats are
computed, the Javascript would return "100px 100px" and the test
would fail.

This test now passes in Chromium/WebKit/Firefox, as all properly compute
one repetition.

Bug: 1449942
Change-Id: I6ccde9511e283eb618fb7a1036b7c31b2b0bcfc6
Reviewed-on: https://chromium-review.googlesource.com/4616678
WPT-Export-Revision: 344b8b46a90dd769eb651fc878624f5006a0e24c

Component: web-platform-tests → Layout: Grid
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2cc688860f3a [wpt PR 40550] - [GridNG] Updates to grid-repeat-max-width-001.html, a=testonly https://hg.mozilla.org/integration/autoland/rev/240a99346683 [wpt PR 40550] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
You need to log in before you can comment on or make changes to this bug.