Closed Bug 1838578 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 40563 - Close other <details> elements linked by name attribute in tree order.

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
116 Branch
Tracking Flags:
Tracking Status
firefox116 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 40563 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40563
Details from upstream follow.

L. David Baron <dbaron@chromium.org> wrote:

Close other <details> elements linked by name attribute in tree order.

When \<details> elements are linked by their common name attribute values
into an exclusive accordion, and one member of the group is closed, this
closes the linked \<details> elements in tree order rather than insertion
order. This reverts much of 34b2758acd53c3ab7ff32bf418334792ad13e523.
The code is simpler but slower, and it matches typical web platform
patterns more closely (even if those patterns may not be ideal in this
case).

This change is based on discussion in
https://github.com/whatwg/html/pull/9400/files#r1221692104

Bug: 1444057
Change-Id: I5eed9e25ff7698e23738e53445c64c0fc3a1b035
Reviewed-on: https://chromium-review.googlesource.com/4617028
WPT-Export-Revision: 2bedddc8b9b47d82a9dde1608053a34fd701639b

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 1 tests and 6 subtests

Status Summary

Firefox

OK : 1
PASS: 1
FAIL: 5

Chrome

OK : 1
PASS: 4
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /html/semantics/interactive-elements/the-details-element/name-attribute.tentative.html [wpt.fyi]
    • basic handling of mutually exclusive details: FAIL (Chrome: PASS)
    • more complex handling of mutually exclusive details: FAIL (Chrome: PASS)
    • mutually exclusive details across multiple names and multiple tree scopes: FAIL (Chrome: PASS)
    • mutation event and toggle event order matches tree order: FAIL (Chrome: FAIL)
    • interaction of open attribute changes with mutation events: FAIL (Chrome: PASS)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/32065645ca9a [wpt PR 40563] - Close other <details> elements linked by name attribute in tree order., a=testonly https://hg.mozilla.org/integration/autoland/rev/e00e7c622fae [wpt PR 40563] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/32065645ca9a
https://hg.mozilla.org/mozilla-central/rev/e00e7c622fae

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox116: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
You need to log in before you can comment on or make changes to this bug.