1838641 - Adjust canvas2d text tests that incorrectly expect whitespace-collapsing behavior

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Jonathan Kew [:jfkthame]]

There are a number of canvas2d text tests that expect CSS whitespace-collapsing behavior in canvas text processing, and we currently fail these.

However, the spec does not call for whitespace collapsing at all; rather, it says:

Replace all ASCII whitespace in text with U+0020 SPACE characters
...
Form a hypothetical infinitely-wide CSS line box containing a single inline box containing the text text, with its CSS properties set as follows:
...
'white-space' 'pre'

and white-space: pre preserves (not collapses) whitespace.

So our behavior (which also matches the other browsers) is correct here, and the tests need adjusting.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1838641 - Fix WPT canvas2d text tests that incorrectly expect CSS whitespace-collapsing behavior. r=#gfx-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f4038cc7295
Fix WPT canvas2d text tests that incorrectly expect CSS whitespace-collapsing behavior. r=gfx-reviewers,lsalzman

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40586 for changes under testing/web-platform/tests

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/9f4038cc7295

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot