1838664 - Implement "browsingContext.setViewport" command

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The browsingContext.setViewport command will allow clients to adjust the size of the visible viewport.

As of now it is not available in the specification but should get merged soon.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The PR got merged and we basically could get started with the implementation. But I would suggest we are waiting for at least the tests Alex is currently working on. The first PR can be found at https://github.com/web-platform-tests/wpt/pull/40584.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I have started to implement this command yesterday and it was not that difficult given that most of the CDP code was already written. While testing I actually noticed a bug in CDP, which we should fix as a follow-up once the BiDi support has been landed.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1838664 - [webdriver-bidi] Implement "browsingContext.setViewport" command.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I'm going to wait until the Webdriver tests are merged and synced to mozilla-central. There are a couple of enhancements that I would like to do for a better coverage.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1838664 - Dont review - [wdspec] add tests for browsingContext.setViewport (#40584)

Already existing tests on the wpt repository which haven't downstreamed yet.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1838664 - [wdspec] Enhanced tests for browsingContext.setViewport.

Depends on D181905

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The patches are fully reviewed and only waiting for the next downstream sync.

Julian, could you please take care of the following while I'm away?

• Abandoning the first revision because it's not needed once Alex' tests are available
• Rebasing the patches including fixes for the merge conflicts mainly for the wpt manifest files
• Landing the patch

Thanks!

Comment 8

[Julian Descottes [:jdescottes]]

pushed to lando

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bcdece3e8f97
[webdriver-bidi] Implement "browsingContext.setViewport" command. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/238a99a8900a
[wdspec] Enhanced tests for browsingContext.setViewport. r=webdriver-reviewers,jdescottes

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41014 for changes under testing/web-platform/tests

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/bcdece3e8f97
https://hg.mozilla.org/mozilla-central/rev/238a99a8900a

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot