1838708 - Remove legacy kinto web extension sync keys form user account state

Status: RESOLVED FIXED

(Firefox :: Firefox Accounts, task, P4)

Description

[Tarik Eshaq [:teshaq]]

The old Kinto web ext storage used to have it's own sync keys, which has since been replaced with Firefox sync keys.

This ticket is to remove the old web ext storage scopedKey and the legacy high-level kExtSync and kExtKbHash entries in the user's account state.

Note that this completely breaks old kinto sync, but that's decommissioned and due to be removed in https://bugzilla.mozilla.org/show_bug.cgi?id=1637465 and https://bugzilla.mozilla.org/show_bug.cgi?id=1803748

Comment 1

[Tarik Eshaq [:teshaq]]

Attachment: Bug 1838708: Removes legacy webext storage keys from account state. r=markh

Comment 2

[Tarik Eshaq [:teshaq]]

Besides a try run in https://treeherder.mozilla.org/jobs?repo=try&revision=ee1879e418a9c0546a8f200cd8c82da862d3b671 and running automated tests locally, I verified the removal is OK by manually upgrading a local build:

• Checked out the default branch
• Built and ran Firefox
• Signed in to a firefox account
• in the browser toolbox, ran await fxAccounts._internal.getUserAccountData() and verified that kExtSync, kExtKbHash and scopedKeys["sync:addon_storage"] exist.
• Checkout out my branch
• built and ran Firefox
• in the browser toolbox, ran await fxAccounts._internal.getUserAccountData() and verified that kExtSync, kExtKbHash and scopedKeys["sync:addon_storage"] DO NOT exist
• verified sync works as expected.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66787f25062d
Removes legacy webext storage keys from account state. r=markh,sync-reviewers

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/66787f25062d