1838724 - Very frequent "XPCOM_MEM_BLOAT_LOG is set, disabling native allocations" warning in debug builds

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Andrew McCreight [:mccr8]]

This warning is extremely common:

WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file tools/profiler/core/platform.cpp:345

In a recent Linux64 debug run I looked at, after 2 other frequent causes of warning spam are fixed, this is the second most common warning, with 189,591 occurrences (only slightly behind the 189,672 most common warning).

XPCOM_MEM_BLOAT_LOG is always set when we're running debug tests. I suspect this is effectively happening every time we create a Gecko process, which is quite frequent.

Is this warning useful? Can it made to be more selective somehow?

It looks like it was added in bug 1596761.

Comment 1

[Greg Tatum [:gregtatum]]

It should probably be removed, there aren't many users of the feature anyway.

Comment 2

[Greg Tatum [:gregtatum]]

Or it could be useful it was made to only be shown when the profiler is started, native allocations is turned on, and the bloat log is activated, but I don't think it's worth it.

Comment 3

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Yeah, I think it might be useful if someone really wants to profile with native allocations feature but fails to do so because of the mem bloat log. But that sounds like it needs some changes on how we handle the features because can't handle it easily with the current way.

Greg, currently this a WARNING level log. How about demoting it to DEBUG_LOG, so it only appers when we enable profiler logs + set the log level to debug?

Comment 4

[Greg Tatum [:gregtatum]]

Sure that would probably be fine. I guess that would only be profiler core folks who have that turned on.

Comment 5

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Thanks for your input! I will submit a patch in a bit.

Comment 6

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1838724 - Convert native allocations warning to a debug log r?gregtatum!

Comment 7

[Andrew McCreight [:mccr8]]

Thanks for the quick fix!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/569ee35398db
Convert native allocations warning to a debug log r=gregtatum

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/569ee35398db