1838752 - DropMutationEvent should handle EVENT_INNER_REORDER

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Nathan LaPré]

We should assert in DropMutationEvent that the given event is not an inner reorder, since that indicates it's already been dropped (which shouldn't happen). At the moment, the error would be confusing, since we'd hit this else block assert as if we were expecting a hide event.

This isn't a big deal, but might be confusing. I noticed it while messing around with event coalescence.

Comment 1

[Nathan LaPré]

Attachment: Bug 1838752: Handle other event types in DropMutationEvent,r?Jamie,eeejay

This revision updates DropMutationEvent such that it handles other event
types besides REORDER, HIDE, and SHOW. If we somehow put a different event
type through this function (particularly an inner reorder, which indicates
a reorder event that's already been dropped), we should (and now do) handle
it more gracefully.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f7d6ae9fcce
Handle other event types in DropMutationEvent,r=eeejay

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/3f7d6ae9fcce