1838828 - Crash in [@ mozilla::TrackBuffersManager::FindSampleIndex]

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Paul Adenot (:padenot)]

Crash report: https://crash-stats.mozilla.org/report/index/fd9d7268-ffa6-4584-8022-87b800230616

MOZ_CRASH Reason: MOZ_CRASH(FindSampleIndex called with invalid arguments)

Top 10 frames of crashing thread:

0  xul.dll  mozilla::TrackBuffersManager::FindSampleIndex  dom/media/mediasource/TrackBuffersManager.cpp:2613
1  xul.dll  mozilla::TrackBuffersManager::Seek  dom/media/mediasource/TrackBuffersManager.cpp:2648
2  xul.dll  mozilla::MediaSourceTrackDemuxer::DoSeek  dom/media/mediasource/MediaSourceDemuxer.cpp:394
3  xul.dll  mozilla::detail::RunnableMethodArguments<StoreCopyPassByRRef<mozilla::media::TimeUnit> >::apply<mozilla::MediaSourceTrackDemuxer, RefPtr<mozilla::MozPromise<mozilla::media::TimeUnit, mozilla::MediaResult, 1> >  const  xpcom/threads/nsThreadUtils.h:1164
3  xul.dll  std::invoke  /builds/worker/fetches/vs/VC/Tools/MSVC/14.29.30133/include/type_traits:1534
3  xul.dll  std::_Apply_impl  /builds/worker/fetches/vs/VC/Tools/MSVC/14.29.30133/include/tuple:974
3  xul.dll  std::apply  /builds/worker/fetches/vs/VC/Tools/MSVC/14.29.30133/include/tuple:979
3  xul.dll  mozilla::detail::RunnableMethodArguments<StoreCopyPassByRRef<mozilla::media::TimeUnit> >::apply  xpcom/threads/nsThreadUtils.h:1162
3  xul.dll  mozilla::detail::MethodCall<mozilla::MozPromise<mozilla::media::TimeUnit, mozilla::MediaResult, 1>, RefPtr<mozilla::MozPromise<mozilla::media::TimeUnit, mozilla::MediaResult, 1> >   xpcom/threads/MozPromise.h:1569
3  xul.dll  mozilla::detail::ProxyRunnable<mozilla::MozPromise<mozilla::media::TimeUnit, mozilla::MediaResult, 1>, RefPtr<mozilla::MozPromise<mozilla::media::TimeUnit, mozilla::MediaResult, 1> >   xpcom/threads/MozPromise.h:1589

This is a bug to investigate the long-standing issue about not being able to retrieve a MediaRawData after a seek, that I've added diagnostic assertions for in bug 1838256.

This indicates that their is an issue somewhere here:

https://searchfox.org/mozilla-central/source/dom/media/mediasource/TrackBuffersManager.cpp#2643-2648

We successfully retrieve an index in which we'll supposedly find the range we're looking for, based on buffered ranges, but then when attempting to find the actual sample, we can't find it. This indicates a mismatch between buffered ranges and actual sample data.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 10 desktop browser crashes on nightly

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jimm, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1838828 - Downgrade assertions to only crash in Nigthly. r?alwu

Comment 4

[Paul Adenot (:padenot)]

Attachment: Bug 1838828 - Fix obsolete comment in Assertions.h: MOZ_RELEASE_ASSERT is no-op only in late beta and release. r?chunmin

This is controlled by this:
https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/moz.configure#125-134

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cffe107089aa
Downgrade assertions to only crash in Nigthly. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/ac180e7135da
Fix obsolete comment in Assertions.h: MOZ_RELEASE_ASSERT is no-op only in late beta and release. r=chunmin

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/cffe107089aa
https://hg.mozilla.org/mozilla-central/rev/ac180e7135da

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 8

[Paul Adenot (:padenot)]

Comment on attachment 9342594 [details]
Bug 1838828 - Downgrade assertions to only crash in Nigthly. r?alwu

Beta/Release Uplift Approval Request

• User impact if declined: Crashes on an assertion that was intended to be nightly-only.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This has baked in nightly for some time, and is identical to the code we're running in release.
• String changes made/needed:
• Is Android affected?: Yes

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9342594 [details]
Bug 1838828 - Downgrade assertions to only crash in Nigthly. r?alwu

Approved for 116.0b4

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/ec3f78086d53
https://hg.mozilla.org/releases/mozilla-beta/rev/28f60d3dfc47

Comment 11

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ec3f78086d53
https://hg.mozilla.org/releases/mozilla-beta/rev/28f60d3dfc47