1838847 - [wpt-sync] Sync PR 40590 - window-management: Do some small cleanups in helpers.js.

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 40590 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40590
Details from upstream follow.

Raphael Kubo da Costa <[e-mail]> wrote:

window-management: Do some small cleanups in helpers.js.

• Remove unnecessary use of async in poll()'s inner function.
• Use assert_implements() rather than assert_true() to check that the API is implemented.

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ce5d41703498543d8fd274d83c9e9929cad9658a

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 2 subtests

Status Summary

Firefox

OK : 4
FAIL: 4

Chrome

OK : 4
PASS: 6
FAIL: 1

Safari

OK : 4
FAIL: 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /window-management/multi-screen-fullscreen-companion.tentative.https.html [wpt.fyi]
  • Enter fullscreen and open a popup from one transient activation.: FAIL (Chrome: PASS, Safari: FAIL)
• /window-management/multi-screen-fullscreen-enter.tentative.https.html [wpt.fyi]
  • Use multi-screen details to enter fullscreen on specific screens: FAIL (Chrome: PASS, Safari: FAIL)
• /window-management/multi-screen-fullscreen-move.tentative.https.html [wpt.fyi]
  • Use multi-screen details to move fullscreen between screens: FAIL (Chrome: PASS, Safari: FAIL)
• /window-management/multi-screen-window-open.tentative.https.html [wpt.fyi]
  • Use multi-screen details to open a popup window on each screen: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be7eeae23cc5
[wpt PR 40590] - window-management: Do some small cleanups in helpers.js., a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/be7eeae23cc5