1838905 - Values for canvas letterSpacing/wordSpacing attributes should be normalized to lowercase

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Jonathan Kew [:jfkthame]]

One reason we fail some letter/word-spacing tests is that they specify a value in uppercase (e.g. ctx.letterSpacing = "1PX"), but on reading back the value, the test expects to see it lowercased.

Currently, we accept such uppercased units (we use a case-insensitive comparison when parsing them), but store them exactly as specified. We should instead normalize them, as the test expects and as is usual for CSS serialization.

Comment 1

[Jonathan Kew [:jfkthame]]

The other thing I'm intending to do here is to split out the spacing testcases using font-relative lengths from those that use absolute lengths. Currently in OffscreenCanvas, we only support absolute lengths. Separating the tests will make it easier to keep track of the status.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1838905 - patch 1 - Normalize values to lowercase when storing canvas2d letter/word-spacing attributes. r=#gfx-reviewers

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1838905 - patch 2 - Split canvas text spacing tests into separate groups for absolute vs font-relative lengths. r=#gfx-reviewers

Also adds a few more examples of font-relative lengths. We currently fail those
in OffscreenCanvas (see bug 1832955).

Depends on D181277

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/950bd58b50e5
patch 1 - Normalize values to lowercase when storing canvas2d letter/word-spacing attributes. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/ee558fb646d4
patch 2 - Split canvas text spacing tests into separate groups for absolute vs font-relative lengths. r=gfx-reviewers,lsalzman

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40610 for changes under testing/web-platform/tests

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/950bd58b50e5
https://hg.mozilla.org/mozilla-central/rev/ee558fb646d4

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot