1838984 - Support [Serializable] for EncodedVideoChunk

Status: RESOLVED FIXED

(Core :: Audio/Video: Web Codecs, task, P1)

Description

[C.M.Chang[:chunmin]]

Bug 1838958 implements a basic EncodedVideoChunk without [Serializable]. [Serializable] will be implemented in this bug.

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1838984 - Add Serializable to EncodedVideoChunk

This patch add Serializable to EncodedVideoChunk interface with some
dummy functions to make it buildable. The (de-)serialization function
will be implemented in the following patches.

Depends on D182843

Comment 2

[C.M.Chang[:chunmin]]

Attachment: Bug 1838984 - Store EncodedVideoChunk data in MediaAlignByteBuffer

EncodedVideoChunk serialization will take a reference to the data
stored in the chunk. Using MediaByteBuffer is a better choice for data
storage since it implies it can be shared.

Comment 3

[C.M.Chang[:chunmin]]

Attachment: Bug 1838984 - Introduce MediaAlignedByteBuffer

This patch addes a MediaAlignedByteBuffer class that is a ref-counted
AlignedByteBuffer. It will be used in the next patch.

Comment 4

[C.M.Chang[:chunmin]]

Attachment: Bug 1838984 - Implement Serializable for EncodedVideoChunk

This patch implements {Read, Write}StructuredClone for
EncodedVideoChunk in the custom fashion to achieve [Serializable] in
EncodeVideoChunk interface.

The data stored in EncodedVideoChunk will be share between the
serialization side and de-serialization side to avoid copy for
performance sake.

Depends on D182844

Comment 5

[C.M.Chang[:chunmin]]

Attachment: Bug 1838984 - Enable EncodedVideoChunk serialization WPT

Depends on D182954

Comment 6

[C.M.Chang[:chunmin]]

Attachment: Bug 1838984 - Add more EncodedVideoChunk serialization WPTs

Comment 7

[C.M.Chang[:chunmin]]

Attachment: Bug 1838984 - Add intra-cluster-shared-object-allowed for serialization

This patch addes a same-origin check for EncodedVideoChunk
serialization. The check is done by comparing the worker's loading
principal with the global's one.

Depends on D183035

Comment 8

[C.M.Chang[:chunmin]]

Attachment: Bug 1838984 - Rename service-worker file for general usage

This service worker will be reused for EncodedVideoChunk's WPT in
patches later, so the file name should remove the VideoFrame prefix.

Depends on D182955

Comment 9

[C.M.Chang[:chunmin]]

Attachment: Bug 1838984 - Label messages for VideoFrame in service-worker

The service worker will no longer be used for VideoFrame only. In the
next patch, it will receive some messages from EncodedVideoChunk's WPTs
as well, so distinguishing messages for VideoFrame from others is
necessary.

Depends on D184133

Comment 10

[C.M.Chang[:chunmin]]

Attachment: Bug 1838984 - Add service-worker WPTs for EncodedVideoChunk serialization

Depends on D183035

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3d88665dcae
Introduce MediaAlignedByteBuffer r=media-playback-reviewers,alwu
https://hg.mozilla.org/integration/autoland/rev/69b480c29c30
Store EncodedVideoChunk data in MediaAlignByteBuffer r=padenot
https://hg.mozilla.org/integration/autoland/rev/ad7f9efb9030
Add Serializable to EncodedVideoChunk r=emilio
https://hg.mozilla.org/integration/autoland/rev/02c281ff169f
Implement Serializable for EncodedVideoChunk r=webidl,smaug
https://hg.mozilla.org/integration/autoland/rev/a8daccb99e00
Enable EncodedVideoChunk serialization WPT r=padenot
https://hg.mozilla.org/integration/autoland/rev/6c009875a7be
Rename service-worker file for general usage r=smaug
https://hg.mozilla.org/integration/autoland/rev/17ace6afea6f
Label messages for VideoFrame in service-worker r=smaug
https://hg.mozilla.org/integration/autoland/rev/cc1f6a7cd4fe
Add more EncodedVideoChunk serialization WPTs r=smaug
https://hg.mozilla.org/integration/autoland/rev/a2573ef16190
Add service-worker WPTs for EncodedVideoChunk serialization r=smaug
https://hg.mozilla.org/integration/autoland/rev/0c46013a7260
Add intra-cluster-shared-object-allowed for serialization r=smaug,padenot

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41141 for changes under testing/web-platform/tests

Comment 13

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c3d88665dcae
https://hg.mozilla.org/mozilla-central/rev/69b480c29c30
https://hg.mozilla.org/mozilla-central/rev/ad7f9efb9030
https://hg.mozilla.org/mozilla-central/rev/02c281ff169f
https://hg.mozilla.org/mozilla-central/rev/a8daccb99e00
https://hg.mozilla.org/mozilla-central/rev/6c009875a7be
https://hg.mozilla.org/mozilla-central/rev/17ace6afea6f
https://hg.mozilla.org/mozilla-central/rev/cc1f6a7cd4fe
https://hg.mozilla.org/mozilla-central/rev/a2573ef16190
https://hg.mozilla.org/mozilla-central/rev/0c46013a7260

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot