1839010 - Forwarding messages as an attachment with the "add extension to file name" preference disabled (mail.forward_add_extension) uses the wrong MIME type

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Simon Arlott]

Steps to reproduce:

1. Set mail.forward_add_extension=false
2. Forward an email that has the subject "test" as an attachment

Actual results:

The attachment has content-type text/plain

Expected results:

The attachment has content-type message/rfc822

Comment 1

[Simon Arlott]

I know this is a hidden preference but it is essential for the significant number of mail servers that are rejecting forwarded messages to abuse@ addresses because they have decided that ".eml files are executable".

Comment 2

[Wayne Mery (:wsmwk)]

Simon, is this still broken for you in version 128?
Please let us know.

Comment 3

[Simon Arlott]

This is still broken in 115.16.0esr

Comment 4

[Wayne Mery (:wsmwk)]

Are you not able to update to 128?

Comment 5

[Simon Arlott]

It's still broken in 133, which commit are you expecting to have fixed this?

Comment 6

[Wayne Mery (:wsmwk)]

(In reply to Simon Arlott from comment #5)

It's still broken in 133, which commit are you expecting to have fixed this?

I don't have any expectations, no fix in mind.

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: Bug 1839010 - Ensure forwared-as-attachment emails (esp for mail.forward_add_extension)false) uses the correctMIME type. r=#thunderbird-back-end-reviewers

... and unify/fix nsIMsgAttachment idl string types.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2e4be0842605
Ensure forwared-as-attachment emails (esp for mail.forward_add_extension)false) uses the correctMIME type. r=tobyp

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 9466451 [details]
Bug 1839010 - Ensure forwared-as-attachment emails (esp for mail.forward_add_extension)false) uses the correctMIME type. r=#thunderbird-back-end-reviewers

[User impact if declined]

• Forwarded emails may not work properly

[Is this code covered by automated tests?]

• Yes

[Has the fix been verified in Daily? (or Beta for an ESR uplift?)]

• Yes

[Needs manual test from QA?]
-No

[List of other uplifts needed]
None

[Risk to taking this patch]
Low. Small isolated change really.

[String changes made/needed]
None

Comment 10

[Corey Bryant]

Comment on attachment 9466451 [details]
Bug 1839010 - Ensure forwared-as-attachment emails (esp for mail.forward_add_extension)false) uses the correctMIME type. r=#thunderbird-back-end-reviewers

[Triage Comment]
Approved for release
Approved for esr128

Comment 11

[Daniel Darnell [:dandarnell]]

Thunderbird 128.8.1esr:
https://hg.mozilla.org/releases/comm-esr128/rev/6fd564fcb986