1839123 - [wdspec] Remove "acceptInsecureCerts" capabilities marker which should no longer be required

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, task)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Given that the wdspec tests use the profile under /testing/profiles now we don't seem to need the acceptInsecureCerts capabilities marker for pytest anymore.

The following instances exist:
https://searchfox.org/mozilla-central/search?q=%40pytest.mark.capabilities(%7B%22acceptInsecureCerts%22%3A%20True%7D)&path=

When removing those we should still check with Safari and Chrome as well. As such it might be better to make those changes directly in the upstream repository.

This change will most likely fix the intermittent failures as recently seen on bug 1769430.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

A try build is at: https://treeherder.mozilla.org/jobs?repo=try&revision=c08233632fe9bf17805f50898afa2fcb67b0887d

The upstream PR for the checks is at: https://github.com/web-platform-tests/wpt/pull/40623

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1839123 - [wdspec] Remove "acceptInsecureCerts" capabilities marker which is no longer required.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed3672832487
[wdspec] Remove "acceptInsecureCerts" capabilities marker which is no longer required. r=webdriver-reviewers,Sasha

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40640 for changes under testing/web-platform/tests

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1839123 - [wdspec] Add back accidentally removed capability selection.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ad5c2418b37
[wdspec] Add back accidentally removed capability selection. r=webdriver-reviewers,Sasha

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ed3672832487

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2ad5c2418b37

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Pulsebot from comment #6)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ad5c2418b37
[wdspec] Add back accidentally removed capability selection.
r=webdriver-reviewers,Sasha

Hi James, as it looks like the wpt bot cannot handle two separately landed commits on the same bug, and didn't create the upstream PR.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Henrik Skupin [:whimboo][⌚️UTC+2] from comment #10)

Hi James, as it looks like the wpt bot cannot handle two separately landed commits on the same bug, and didn't create the upstream PR.

Actually wpt bot silently folded in this extra commit in the already created PR, which is merged now.