1839141 - [wpt-sync] Sync PR 40616 - [css-nesting] Support nested @layer rules

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 40616 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40616
Details from upstream follow.

Anders Hartvoll Ruud <[e-mail]> wrote:

[css-nesting] Support nested @layer rules

This CL adds support for nested @layer rules, using the same boilerplate
we use for other rules (@media, etc).

This was not part of the initial release of css-nesting, because it was
added to the specification too late in the process. However, the intent
of the spec is to allow nesting of all at-rules that contain style rules
in their body [1].

Renamed AllowedRulesType::kConditionalGroupRules to kNestedGroupRules,
since it's not just conditional rules that are allowed to nest anymore.

[1] https://drafts.csswg.org/css-nesting/#nested-group-rules

Fixed: 1455887
Bug: 1451088
Change-Id: I76a9463442bec3e7e6425ddc851ddbf14690604b
Reviewed-on: https://chromium-review.googlesource.com/4624568
WPT-Export-Revision: 7aedbbd952deda9d4008112b5a1b61da828b824b

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=23b0d79b5afbe0c894b603fc256da7d7625155b6

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-nesting/nesting-layer.html [wpt.fyi]
  • @layer can be nested: FAIL (Chrome: FAIL, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c64c9dbf0a1
[wpt PR 40616] - [css-nesting] Support nested @layer rules, a=testonly
https://hg.mozilla.org/integration/autoland/rev/4c9c7e6bb6fd
[wpt PR 40616] - Update wpt metadata, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5c64c9dbf0a1
https://hg.mozilla.org/mozilla-central/rev/4c9c7e6bb6fd