1839177 - In nsUnknownDecoder::ConvertEncodedData OnStopRequest won't be called in some cases after OnStartRequest

Status: NEW

(Core :: Networking: HTTP, defect, P2)

Description

[Manuel Bucher [:manuel]]

Also discussed after the patch introducing this landed: https://bugzilla.mozilla.org/show_bug.cgi?id=1418545#c10

In these lines: https://searchfox.org/mozilla-central/rev/c936f47f3a629ae49a4d528d3366bf29f2d4e4a7/netwerk/streamconv/converters/nsUnknownDecoder.cpp#767,770,773

Comment 1

[Manuel Bucher [:manuel]]

Attachment: Bug 1839177 - Always call OnStopRequest after OnStartRequest even with failures in OnDataAvailable in nsUnknownDecoder::ConvertEncodedData r=#necko

The contract is that after calling OnStartRequest once we then MUST call OnStopRequest, once.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5276a2dbe3d2
Always call OnStopRequest after OnStartRequest even with failures in OnDataAvailable in nsUnknownDecoder::ConvertEncodedData r=necko-reviewers,kershaw

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing wpt failures in /fetch/content-encoding/bad-gzip-body.any.worker.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/936de0ebea835b1d1ac7899f4c1f1d69deb9ed44

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | /fetch/content-encoding/bad-gzip-body.any.worker.html