1839205 - Volume percentage is set to 100% when unmuting PiP video by clicking speaker icon

Status: NEW

(Toolkit :: Picture-in-Picture, defect, P3)

Description

[Peter Magyari (Desktop QA)]

Note

• If you unmute the video in PiP by using the shortcut (ctrl+up arrow) the volume is set back to the volume percentage accordingly.

Found in

• Firefox Nightly 116.0a1

Affected versions

• Firefox Nightly 116.0a1

Tested platforms

• Affected platforms: All

Steps to reproduce

1. Start playing a video and launch Picture-in-Picture.
2. Lower the volume of the video to 30% (or anything other than 0/100%) using the volume slider.
3. Click the speaker icon or use the mute shortcut to mute the video.
4. Press back-to-tab to unpip.
5. Launch PiP again.
6. Unmute the video by clicking the speaker icon.

Expected result

• The video is unmuted and the volume is set to the percentage it was muted from originally (30%).

Actual result

• The video is unmuted but the volume is set to 100%.

Regression range

• Not a regression, the volume slider was added in Nightly 116.

Comment 1

[CoolCmd]

The unmute is still bugged in Firefox 130 release -- it changes the volume to 100%!! IT IS SOOOOO LOUD THAT I NEVER MUTE/UNMUTE FROM PIP.
How many years will it take for this error to be fixed?

Comment 2

[kpatenio]

Hmm, I think we'll need to modify the mute/unmute logic in https://searchfox.org/mozilla-central/rev/f549a50b1e39b1e6bea19912d92545c4c0a06b7b/toolkit/components/pictureinpicture/content/player.js#799-806. We rely on the volume slider value to revert back to the right volume level, but that value gets lost when we close + re-open PiP, falling back to 1 (max volume).

Comment 3

[CoolCmd]

or better, do not touch the slider on mute.