1839223 - Mapped attributes lose source order with respect to non-mapped attributes.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

test-case:

data:text/html,<div data-bar="foo" align="left" data-foo="bar"></div><script>document.body.appendChild(document.createTextNode(document.querySelector("div").outerHTML))</script>

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1839223 - Remove nsMappedAttributes. r=smaug

Comment 2

[Emilio Cobos Álvarez (:emilio)]

https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=f3461f0c170ae17e77001e0be17111d944ff98d1&newProject=try&newRevision=726e0ddd4bb6cb4747cfde3954fe9067089c2005&page=1&framework=10

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1839223 - Move table cellpadding handling to HTMLTableElement. r=smaug

As per discussion.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3e55d5f9f13
Remove nsMappedAttributes. r=smaug

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7f9502a36c0
Move table cellpadding handling to HTMLTableElement. r=smaug

Comment 6

[Cristian Tuns]

Backed out for causing multiple failures in Document.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: Assertion failure: inserted, at /builds/worker/checkouts/gecko/dom/base/Document.cpp:8660

Failure log 2: https://treeherder.mozilla.org/logviewer?job_id=420306092&repo=autoland

Also WPT failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=b9e51e69d0451a93822b61cc15d72666124f02dd&searchStr=wpt&selectedTaskRun=cYo5bAtYRoCgxxsUEiWIcA.0

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6d5233d9f60
Remove nsMappedAttributes. r=smaug

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40711 for changes under testing/web-platform/tests

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b6512e2c601
Update failure annotations of sizes-auto.html

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e7f9502a36c0
https://hg.mozilla.org/mozilla-central/rev/c6d5233d9f60
https://hg.mozilla.org/mozilla-central/rev/3b6512e2c601

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot