Closed Bug 1839338 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 40636 - Clone encoded WebRTC audio frame when deserializing RTCEncodedAudioFrame

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox116 fixed)

RESOLVED FIXED
116 Branch
Tracking Status
firefox116 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 40636 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40636
Details from upstream follow.

Tony Herre <toprice@chromium.org> wrote:

Clone encoded WebRTC audio frame when deserializing RTCEncodedAudioFrame

This fixes the issue that structuredClone() returns an
RTCEncodedAudioFrame using the same underlying frame as the original.

Bug: 1450844, 1456292
Change-Id: I9812ea3652b6ef4ae5f0f6d5a8d11abe456de1a7

Reviewed-on: https://chromium-review.googlesource.com/4626956
WPT-Export-Revision: e32665e38583c8c3ac20f24b44eb3e540e1d3069

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 7 subtests

Status Summary

Firefox

OK : 1
FAIL : 7

Chrome

CRASH: 1

Safari

OK : 1
FAIL : 7

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /webrtc-encoded-transform/RTCPeerConnection-insertable-streams-audio.https.html [wpt.fyi]
    • Frames flow correctly using insertable streams: FAIL (Safari: FAIL)
    • Frames flow correctly using insertable streams when receiver starts negotiation: FAIL (Safari: FAIL)
    • RTCRtpSender.createEncodedStream() throws if not requested in PC configuration: FAIL (Safari: FAIL)
    • RTCRtpReceiver.createEncodedStream() throws if not requested in PC configuration: FAIL (Safari: FAIL)
    • Enqueuing the same frame twice fails: FAIL (Safari: FAIL)
    • Creating streams twice throws: FAIL (Safari: FAIL)
    • Encoded frames serialize and deserialize into a deep clone: FAIL (Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/676e8e3f1c1a [wpt PR 40636] - Clone encoded WebRTC audio frame when deserializing RTCEncodedAudioFrame, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
You need to log in before you can comment on or make changes to this bug.