1839363 - fatal error: asm/hwcap.h: No such file or directory when compiling highway on ppc64le

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Dan Horák]

A somewhat recent update to highway broke build on ppc64le

...
 0:24.25 media/highway/targets.o
 0:24.25 /usr/bin/g++ -o targets.o -c  -I/home/sharkcz/projects/firefox/obj-powerpc64le-unknown-linux-gnu/dist/stl_wrappers -I/home/sharkcz/projects/firefox/obj-powerpc64le-unknown-linux-gnu/dist/system_wrappers -include /home/sharkcz/projects/firefox/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DNDEBUG=1 -DTRIMMED=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/home/sharkcz/projects/firefox/media/highway -I/home/sharkcz/projects/firefox/obj-powerpc64le-unknown-linux-gnu/media/highway -I/home/sharkcz/projects/firefox/third_party/highway -I/home/sharkcz/projects/firefox/obj-powerpc64le-unknown-linux-gnu/dist/include -I/home/sharkcz/projects/firefox/obj-powerpc64le-unknown-linux-gnu/dist/include/nspr -I/home/sharkcz/projects/firefox/obj-powerpc64le-unknown-linux-gnu/dist/include/nss -DMOZILLA_CLIENT -include /home/sharkcz/projects/firefox/obj-powerpc64le-unknown-linux-gnu/mozilla-config.h -fno-sized-deallocation -fno-aligned-new -fno-exceptions -fPIC -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe -gdwarf-4 -freorder-blocks -O2 -fno-omit-frame-pointer -funwind-tables -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wno-invalid-offsetof -Wc++2a-compat -Wcomma-subscript -Wvolatile -Wno-error=deprecated -Wno-error=deprecated-enum-enum-conversion -Wduplicated-cond -Wimplicit-fallthrough -Wlogical-op -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-multistatement-macros -Wno-error=class-memaccess -Wformat -Wformat-overflow=2 -Wno-psabi -Wno-error=builtin-macro-redefined -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/targets.o.pp  -fdiagnostics-color  /home/sharkcz/projects/firefox/third_party/highway/hwy/targets.cc
 0:24.36 /home/sharkcz/projects/firefox/third_party/highway/hwy/targets.cc:45:10: fatal error: asm/hwcap.h: No such file or directory
 0:24.36    45 | #include <asm/hwcap.h>
 0:24.36       |          ^~~~~~~~~~~~~
 0:24.36 compilation terminated.

There is #ifndef TOOLCHAIN_MISS_ASM_HWCAP_H guard in third_party/highway/hwy/targets.cc, but the value is not defined by the build system. I think an update to media/highway/moz.build should fix it.

Comment 1

[Dan Horák]

diff --git a/media/highway/moz.build b/media/highway/moz.build
index b7f51c01334e..67de5725f64a 100644
--- a/media/highway/moz.build
+++ b/media/highway/moz.build
@@ -8,6 +8,10 @@ LOCAL_INCLUDES += [
     "/third_party/highway/",
 ]
 
+if CONFIG["CPU_ARCH"] == "ppc64" and CONFIG["OS_TARGET"] == "Linux":
+
+    DEFINES["TOOLCHAIN_MISS_ASM_HWCAP_H"] = True
+
 SOURCES += [
     "/third_party/highway/hwy/aligned_allocator.cc",
     "/third_party/highway/hwy/contrib/image/image.cc",

seems to fix the issue for me, going to submit as a proper patch ...

Comment 2

[Dan Horák]

Attachment: Bug 1839363 - hwcap.h is missing on ppc64le

Upstream highway project has a check for the availability of the asm/hwcap.h
header, because it doesn't exist on all platforms. Work around it statically
in moz.build.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7dc887b93655
hwcap.h is missing on ppc64le r=saschanaz

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/7dc887b93655