Open Bug 1839448 Opened 1 year ago Updated 1 year ago

Remove nsIHttpAuthenticator.idl and move nsISupports** parameters to nsCOMPtr<>*'s (etc)

Categories

(Core :: Networking, enhancement, P3)

Product:
Core
Component:
Networking
Type:
enhancement

Tracking

()

People

(Reporter: jesup, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

We have raw nsISupports* pointers in the HttpAuthentication code.
It turns out that nsIAuthenticator.idl isn't actually needed (no JS calls generateCredentials() or challengeReceived(), which use inout nsISupports parameters; it's not [scripted]). By moving this interface to normal c++ header entries, we can get rid of the awkward dances to use nsISupports**'s, NS_IF_RELEASE(), etc.

This is the last use in the tree of an inout parameter for a refcounted type.

Use of raw pointers like this is inherently error-prone, leading to potential security issues.

Blocks: necko-tech-debt
Severity: -- → S4
Priority: -- → P3
Whiteboard: [necko-triaged]
You need to log in before you can comment on or make changes to this bug.