1839555 - Get rid of `nsIFormController::AllowDrop`

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

It's introduced in bug 206859, however, in bug 345195, we have replaced <input type="text"> in <input type="file"> with <label>. Therefore, the only user in EditorBase of nsIFormControl::AllowDrop() can stop using it and we can get rid of the API.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1839555 - Get rid of `nsIFormControl::AllowDrop` r=#dom-core!

It was introduced in bug 206859, but the <input type="text"> in
<input type="file"> was replaced in bug 345195. Additionally, it's
used only by EditorBase to check <input type="text"> is in
<input type="file">. Therefore, we don't need it anymore.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1839555 - Add automated test for bug 206859 r=peterv!,#dom-core!

Bug 206859 didn't add a test. And now, we don't have <input type="text">
in the native anonymous subtree of <input type="file">. Therefore, this
patch adds API to retrieve the elements in the native anonymous subtree
and make the test check whether the dropped text is handled by the file
control.

Depends on D181599

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd3f2100f374
Get rid of `nsIFormControl::AllowDrop` r=dom-core,peterv

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/bd3f2100f374