1839727 - [about:welcome] Embedded Migration Wizard doesn't load on back navigation

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Punam Dahiya [:pdahiya]]

STR in Fx116 Nigthly

1. Open about:config and set pref value browser.migrate.content-modal.about-welcome-behavior to embedded
2. Open about:welcome and navigate to Import screen
3. Click Import or Skip button to navigate to next screen (Mobile or Gratitude)
4. Click back button to navigate to last screen
5. Import Screen with Embedded Wizard doesn't load fully (See attached)

[Expected result]
Import Screen loads showing embedded import wizard

This issue doesn't replicate in Fx115 beta

Comment 1

[Punam Dahiya [:pdahiya]]

Attachment: Embedded Import Screen on back navigation.png

Comment 2

[Punam Dahiya [:pdahiya]]

NI @mconley to help debug and provide feedback of any recent changes in Fx116 that could have caused this regression thanks!

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Looking.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Okay, I see what happened here. I have a patch, just writing a test now.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1823537

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1839727 - Allow MigrationWizardChild to bind to a new <migration-wizard>. r?kpatenio!,pdahiya!

This is because about:welcome creates a new <migration-wizard> every time
the import card is navigated to. The change to MigrationWizardChild allows
it to re-bind to the most recently <migration-wizard> to fire one of its
events.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/210d3c5c2f2e
Allow MigrationWizardChild to bind to a new <migration-wizard>. r=kpatenio,pdahiya

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/210d3c5c2f2e

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1823537

Comment 10

[Marius Coman [:mcoman], Ecosystem QA - PTO until 8th of November, for any requests ping :cmuresan]

I have verified that this issue is no longer reproducible using the latest Firefox Beta 116.0b8 (Build ID: 20230720200012) installed on Windows 10 x64, macOS 13.4.1, and Linux Mint 21.1. I can confirm that the "Import Browser Data" Onboarding screen is successfully redisplayed if the browser's "Back" button is clicked.