1839775 - Remove HTMLElement.tap in AccessibleCaret marionette tests

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

In bug 1792529, HTMLElement.tap will be removed. Per bug 1792529 comment 13, we should use pointer_down and pointer_up to simulate tap in AccessibleCaret marionette tests.

https://firefox-source-docs.mozilla.org/python/marionette_driver.html#marionette_driver.marionette.ActionSequence

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thank you Ting-Yu for filing this bug and the willingness to work on! I appreciate. To give you some more guidance - also because the docs are not complete - here a test file which exercises some mouse (not touch) pointer events:

https://searchfox.org/mozilla-central/source/testing/marionette/harness/marionette_harness/tests/unit/test_mouse_action.py

It should help you to modify the tests accordingly. Again thank for working on it and responding that quickly!

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1839775 - Use marionette action instead of HTMLElement.tap() in AccessibleCaret tests.

HTMLElement.tap() is going to be removed in bug 1792529, so reimplement it in
selection.py.

This patch doesn't change the behavior. Althogh I'll have to sprinkle a few
pause() between cursor movement and tap() to increase the stability of the
cursor mode tests.

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1839775 - Use marionette action instead of HTMLElement.tap() in AccessibleCaret tests.

HTMLElement.tap() is going to be removed in bug 1792529.

This patch doesn't change the behavior.

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1839775 - Remove accessbility tests using HTMLElement.tap().

These unit tests verify HTMLElement.tap() with accessibility checks. Since tap()
is going to be removed in bug 1792529, we can remove these tests as well. Note
that HTMLElement.click() is similar to tap(), and is still covered in the file.

Depends on D182088

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c71066111cc6
Use marionette action instead of HTMLElement.tap() in AccessibleCaret tests. r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/914c3b4eeaf8
Remove accessbility tests using HTMLElement.tap(). r=webdriver-reviewers,whimboo

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c71066111cc6
https://hg.mozilla.org/mozilla-central/rev/914c3b4eeaf8